[#12668] - Skip the "crypt-blowfish without salt" test for HHVM
- Closed
- 26 Nov 2016
- Medium
- Build: staging
- # 12668
- Diff
- photodude:patch-11
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue crypt-blowfish without salt fails on HHVM due to facebook/hhvm#7420 since our default salt code for crypt-blowfish is resulting in crypt() falling back to DES.
A full fix is in #12428 but requires complicated sufficient regression tests to ensure a password generated pre-patch should still validate correctly post-patch. Since passwords for regression tests would need to be generated by a version of Joomla prior to 3.2.1 when hashPassword() and verifyPassword() were implemented. this gets a bit complicated.
Note: this function is completely removed in 4.0
Summary of Changes
This function is deprecated and no longer used in core, and since this portion of the test has a configuration issue on HHVM it is skipped. Rather that skipping the whole test, we skip only the singular test that is an issue due to the configuration of our "default salt".
Testing Instructions
HHVM will no longer report the failure of this deprecated function that is no longer used in core
Documentation Changes Required
none, although it has been suggested to mark getCryptedPassword() and getSalt() as "as potentially dangerous and only included for backwards compatibility, since 3.2.2 use hashPassword() and verifyPassword() and look forward to 4.0, where getCryptedPassword() and getSalt() functions have been removed."
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Unit Tests |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-26 18:29:35 |
| Closed_By | ⇒ | photodude |
From @mbabker 's comments
as such this alternative PR is closed. see #12428 for a solution to this issue