? ? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
31 Oct 2016

Pull Request for Issue #12336 on staging.
Replaces closed issue #12341

Summary of Changes

We use semicolons ; everywhere else in database DSN test setups, we should here as well to be consistent.

Note: Although this change won't be needed whenever HHVM 3.16.0 (and hopefully 3.15.3 LTS) gets released in the next few weeks; We should be consistent in our use of DSN separators in all test setups unless there is a specific need to use a different syntax.

Testing Instructions

Fixes the "PDOException: [112]: could not translate host name" issue in the HHVM postgresql tests,

Documentation Changes Required

none

avatar photodude photodude - open - 31 Oct 2016
avatar photodude photodude - change - 31 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Category Unit Tests
avatar photodude photodude - change - 31 Oct 2016
The description was changed
avatar photodude photodude - edited - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Removed: ?
avatar photodude photodude - change - 31 Oct 2016
The description was changed
avatar photodude photodude - edited - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - merge - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - reference | d8fe642 - 31 Oct 16
avatar zero-24 zero-24 - merge - 31 Oct 2016
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-31 21:46:59
Closed_By zero-24
avatar zero-24 zero-24 - change - 31 Oct 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 31 Oct 2016

Thanks ?

avatar photodude
photodude - comment - 31 Oct 2016

You are welcome.

avatar photodude photodude - head_ref_deleted - 31 Oct 2016

Add a Comment

Login with GitHub to post a comment