Nice improvement

Please mark the test OK on issues.joomla.org

I will as soon as I have tested it

@infograf768 although I like this, I am gonna say I am against it for a simple reason: consistency. Think of the following case, user updates their site which got a few 3rdPD components. Core will be line Articles: Fields and everything else will be just Fields. So this will confuse people...

@dgt41 doesnt the 3pd component have to be updated to support fields? They
dont just appear automatically on every component iirc

On 31 October 2016 at 09:22, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@infograf768 https://github.com/infograf768 although I like this, I am
gonna say I am against it for a simple reason: consistency. Think of the
following case, user updates their site which got a few 3rdPD components.
Core will be line Articles: Fields and everything else will be just Fields.
So this will confuse people...

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bWVs1etWlXYAMrn7xyP56tAt7yCks5q5bNsgaJpZM4KkxNG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@brianteeman mea culpa, I thought this was happening automagically

@dgt41

Not sure I understand...
If a 3pd implements custom fields, it is their job to add similar strings. This is similar to _SAVE_SUCCESS, etc.
The fields and field groups are specific to each component using them.
If the 3pd component is NOT using com_fields, the fields and field Groups are just not proposed by the component.

The code in view.thml.php is made to implement this (for extensions that use com_fields)

// If a component categories title string is present, let's use it.
        if ($lang->hasKey($component_title_key = strtoupper($component . '_FIELDS_' . ($section ? $section : '')) . '_FIELDS_TITLE'))
        {
            $title = JText::_($component_title_key);
        }
        elseif ($lang->hasKey($component_section_key = strtoupper($component . '_FIELDS_SECTION_' . ($section ? $section : ''))))
        {
            // Else if the component section string exits, let's use it
            $title = JText::sprintf('COM_FIELDS_VIEW_FIELDS_TITLE', $this->escape(JText::_($component_section_key)));
        }
        else
        {
            $title = JText::_('COM_FIELDS_VIEW_FIELDS_BASE_TITLE');
        }

BTW, found another weird issue when debugging language and editing an article Field Group:

*Not loaded** : JROOT/administrator/language/en-GB/en-GB.com_contentarticlefields.sys.ini
**Not loaded** : JROOT/administrator/components/com_contentarticlefields/language/en-GB/en-GB.com_contentarticlefields.sys.ini

Similar when editing a user Field Group

**Not loaded** : JROOT/administrator/language/en-GB/en-GB.com_usersuserfields.sys.ini
**Not loaded** : JROOT/administrator/components/com_usersuserfields/language/en-GB/en-GB.com_usersuserfields.sys.ini

I have tested this item ✅ successfully on 788ec79

works as described

I have tested this item ✅ successfully on 788ec79

RTC