? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
30 Oct 2016

Summary of Changes

Use the new native name metadata in installed languages view

image

Testing Instructions

  1. Use latest staging
  2. Apply patch
  3. Go to Extensions >Languages > Installed
  4. Check there is a new column (Native Title) with the info
  5. Test site and admin languages.

The code was also optimized to use the new JLanguageHelper::getInstalledLanguages method.

Documentation Changes Required

None.

@infograf768 please check this.

avatar andrepereiradasilva andrepereiradasilva - open - 30 Oct 2016
avatar andrepereiradasilva andrepereiradasilva - change - 30 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2016
Category Administration Components
avatar andrepereiradasilva andrepereiradasilva - change - 30 Oct 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 30 Oct 2016
avatar andrepereiradasilva andrepereiradasilva - change - 30 Oct 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 30 Oct 2016
avatar infograf768
infograf768 - comment - 31 Oct 2016

not sure i like the "unknown" as it would look bad on older packs.
may be just leave it empty ?

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Oct 2016

yes we can, will add a - then

a0388f4 31 Oct 2016 avatar andrepereiradasilva Add -
avatar andrepereiradasilva andrepereiradasilva - change - 31 Oct 2016
The description was changed
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Oct 2016

done

avatar brianteeman
brianteeman - comment - 31 Oct 2016

Sorry i am confused
The Native Language column is complete in the content language view and incomplete in the installed language view

image

image

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Oct 2016

@brianteeman the native name for a language is a new metadata value for the site/admin language, when the language packs translate that metadata value it will apeear here.

The content languages use other method since, IIRC, they fallback to the name, and if installed using install they even fallback to a language var in installation ini. See https://github.com/joomla/joomla-cms/blob/staging/installation/language/en-GB/en-GB.ini#L187

This was made to preserve B/C.

In the future this nativeName metadata should be the native title used for all views: Installed languages, Content Languages and Installation.

avatar brianteeman
brianteeman - comment - 31 Oct 2016

I have tested this item successfully on a0388f4

Does what you say it will do althuough kind of hard to test if no language supports this yet


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12641.

avatar brianteeman brianteeman - test_item - 31 Oct 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Oct 2016

Does what you say it will do althuough kind of hard to test if no language supports this yet

They will in 3.7.0. See for instance https://crowdin.com/translate/joomla-cms/532/engb-pt

avatar infograf768 infograf768 - test_item - 1 Nov 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Nov 2016

I have tested this item successfully on 9664316


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12641.

avatar infograf768 infograf768 - alter_testresult - 1 Nov 2016 - brianteeman: Tested successfully
avatar infograf768 infograf768 - change - 1 Nov 2016
The description was changed
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 1 Nov 2016

RTC

screen shot 2016-11-01 at 01 47 51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12641.

avatar joomla-cms-bot joomla-cms-bot - edited - 1 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 1 Nov 2016

@andrepereiradasilva
Note: I remarked that updating a language pack via Extensions=>Install=>Upload Package File does not create a Content Language.
If a pure install (i.e. NOT updating), the Content language is created.
You may want to look into this

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Nov 2016

@infograf768 not related to this PR will check that in another PR if needed

avatar alikon
alikon - comment - 1 Nov 2016

@andrepereiradasilva just noticed that in a pure install (i.e. NOT updating), the Content languages other than en-GB - English are not more created with postgresql , some other PR's maybe have create these issues

avatar brianteeman brianteeman - change - 3 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - change - 4 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-04 09:08:04
Closed_By rdeutz
avatar rdeutz rdeutz - close - 4 Nov 2016
avatar rdeutz rdeutz - merge - 4 Nov 2016
avatar rdeutz rdeutz - reference | 3551ed4 - 4 Nov 16
avatar rdeutz rdeutz - merge - 4 Nov 2016
avatar rdeutz rdeutz - close - 4 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 4 Nov 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Nov 2016

@andrepereiradasilva just noticed that in a pure install (i.e. NOT updating), the Content languages other than en-GB - English are not more created with postgresql , some other PR's maybe have create these issues

Seems to be database related. Can you open a new issue @alikon ?

Add a Comment

Login with GitHub to post a comment