[#12640] - Add Tag filter
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12640
- Diff
- Bakual:AddTagFilterToBlog
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request to add tag filter option to article blog menu item
Summary of Changes
Adds a new parameter to the menuitem for category article blogs. The necessary code for the actual filtering is already present in the model for quite some time.
Testing Instructions
Create a new menu item for the com_content articles blog and select a tag in the menu item.
You should only get the articles with that selected tag.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
The code works perfectly - unfortunately the text for the tooltip is completely wrong
you will need to add a new string in en-GB.ini
JTAGS_FIELD_SELECT="Select the tag to use."
| Category | Front End Components | ⇒ | Administration Language & Strings Front End com_content Components |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12640.
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
I had to manually do the one (was for wrong branch) and messed it up a bit. But now it should be fine.
Thanks for the input!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12640.
this seems to work fine, some comments (maybe for another PR):
- Shouldn't we allow several tags, instead of just one?
- Shouldn't we made the same funcionality to category list menu too?
- Shouldn't we made the same funcionality to all menu category in other components too (ex: list contacts in a category)?
I thought the same but its for another pr.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12640.
Shouldn't we allow several tags, instead of just one?
The current code (https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/articles.php#L88-L89) only allows an integer. If you want multiple tags, you will have to adjust the filtering code first so it can take an array of ids (and for B/C an integer). Com_tags itself has several places where it accepts a single tag, a coma-separated list of tags or an array of tags. We had some not-so-funny security issues because of that.... So if you want to do it, make sure input filtering is done properly.
Shouldn't we made the same funcionality to category list menu too?
Shouldn't we made the same funcionality to all menu category in other components too (ex: list contacts in a category)?
If you think this is important, feel free to make a PR. I just did this to show it's already possible.
Sure. it can be other PR.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12640.
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:34:41 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on ff875da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12640.