[#12635] - [4.0] Fix "An error has occurred."
- Fixed in Code Base
- 12 Nov 2016
- Medium
- Build: 4.0-dev
- # 12635
- Diff
- andrepereiradasilva:patch-11
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Since #12494 merge we get an error in all backend pages.
So this PR solves the issue, and gives that error message more info (error message with "An error as occured" is the same as saying nothing ...), for when it occurs.
Testing Instructions
- Use latest 4.0
- See the error in the backend
- Apply patch
- No error ### Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Modules Administration |
| Title |
|
||||||
| Title |
|
||||||
This looks good for the SQL query. Can we not print the exception message tho. Exception messages are generally hard coded to English which gives multilang issues and also probably contains more technical information that is of no use to end users. If we need to let's log the exception instead :)
sorry george, but "An error has occurred." is nothing. What does this mean?
Is like "A warning was detected." ... or "A message exists."
If we need to let's log the exception instead :)
My first idea, but we can't the way the error page is done. Because this is an error while building the admin menu, if we trow an exception here the error page comes back without admin menu and you can't see the message.
mbabker
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-12 18:05:06 |
| Closed_By | ⇒ | mbabker |
zero-24
-
@wilsonge @zero-24 please check
This is related to mysql strict mode. Could be backported to staging too.