[#12634] - Subform.Repeatable styling (alternative to #12419)
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12634
- Diff
- ciar4n:subform-restyle2
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is an alternative PR to #12419 based on the suggestion by @coolcat-creations
Summary of Changes
A PR to add some styling to repeatable subforms (joomla.form.field.subform.repeatable).
Testing Instructions
Create ../modules/mod_login/test.xml to which add the following...
<?xml version="1.0" encoding="UTF-8"?>
<form>
<fieldset name="sample" class="sample-subform">
<field name="image" type="media" default="" label="Sample Field 1" description="Desc1" size="30" />
<field name="text" type="text" default="" label="Sample Field 2" description="Desc2" />
<field name="color" type="color" default="#dddddd" label="Sample Field 2" description="Desc2" />
</fieldset>
</form>
Add the following to the ../modules/mod_login/mod_login.xml file:
<field name="subformtest" type="subform" formsource="modules/mod_login/test.xml" class="advancedSelect" min="0" max="50" multiple="true" layout="joomla.form.field.subform.repeatable" groupByFieldset="true" label="Repeatable Subform" description="Desc" />
Before Patch
After Patch
Note: Tried changing the icons directly (../layouts/joomla/form/field/subform/repeatable/secion.php) however any changes here did not reflect within the form. Possibly the wrong place? Changed the icons with CSS instead which is not ideal.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Templates (admin) |
please, do not forget, there also joomla.form.field.subform.repeatable-table layout, for render fields as table.
whether current changes do not break that layout?
I have tested this item
Thank you!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12634.
@coolcat-creations Thank you for testing. I'd be happy to go with this over #12419 if you are.
Cool, thank you! Then we need just a second test. Thank you for this improvement!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12634.
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Pending |
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12634.
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:33:55 |
| Closed_By | ⇒ | rdeutz |
The template.less is becoming extremely bulky now. We're using LESS, so I think it's time to start separating stuff into separate files, so it's easier to maintain.
+1 for the styling changes though, looking good.