? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
29 Oct 2016

Pull Request for Issue #12607 .

Testing Instructions

Set default template to Hathor and try to change the module position

Also test #11040 with Isis template, to be sure nothing broken

Documentation Changes Required

none

avatar Fedik Fedik - open - 29 Oct 2016
avatar Fedik Fedik - change - 29 Oct 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2016
Category ⇒ JavaScript
avatar infograf768
infograf768 - comment - 30 Oct 2016

Although this lets now display a modal to choose positions, it also transforms many fields to chosen dropdowns in Hathor.
Status, Access, Language, etc. etc.

screen shot 2016-10-30 at 08 23 03
This is therefore insufficient and can't be merged as is.

avatar Fedik
Fedik - comment - 30 Oct 2016

it also transforms many fields to chosen dropdowns in Hathor.

not really, this pull remove Chosen from the position input.
The Chosen actually was added in #11040, but was broken in the Hathor ?

but I will check, what can do here

avatar Fedik
Fedik - comment - 30 Oct 2016

@infograf768 please test again ?

avatar dgt41 dgt41 - test_item - 31 Oct 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 31 Oct 2016

I have tested this item ✅ successfully on 314cb6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12621.

avatar infograf768 infograf768 - test_item - 31 Oct 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 31 Oct 2016

I have tested this item ✅ successfully on 314cb6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12621.

avatar infograf768 infograf768 - change - 31 Oct 2016
The description was changed
Title
…
Fix for Module Positions inaccessable wit Hathor admin Template
Fix for Module Positions inaccessible wit Hathor admin Template
Status Pending ⇒ Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - edited - 31 Oct 2016
avatar infograf768
infograf768 - comment - 31 Oct 2016

RTC. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12621.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Category JavaScript ⇒ Layout JavaScript
avatar zero-24 zero-24 - close - 31 Oct 2016
avatar zero-24 zero-24 - merge - 31 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - close - 31 Oct 2016
avatar zero-24 zero-24 - change - 31 Oct 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-10-31 13:46:40
Closed_By ⇒ zero-24
avatar zero-24
zero-24 - comment - 31 Oct 2016

Merged. Thanks!

avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment