?
avatar zero-24
zero-24
28 Oct 2016

Steps to reproduce the issue

  • 3.6.4 / staging (testing sample data)
  • Add an Article Category module on position-8 (protostar)
  • featured articles -> 2
  • kategorie filter inklusiv
  • datum yes
  • Introtext yes
  • limit 300

Expected result

Everything is correctly renderd in the frontend

Actual result

paste

Additional comments

It looks like the loadmodule is killing the module output.

Thanks @degobbis for finding and reporting ?

avatar zero-24 zero-24 - open - 28 Oct 2016
avatar brianteeman brianteeman - change - 28 Oct 2016
Category Modules Plugins
avatar brianteeman
brianteeman - comment - 28 Oct 2016

not on a site with the sample content but tried to replicate everything in this report and i can not


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12612.

avatar zero-24
zero-24 - comment - 28 Oct 2016

You need to have a load module in the first 300 chars of the introtext ;)

avatar brianteeman
brianteeman - comment - 28 Oct 2016

i did - i had a loadmodule image and this was stripped from the output

On 28 October 2016 at 20:15, zero-24 notifications@github.com wrote:

You need to have a load module in the first 300 chars of the introtext ;)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12612 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Z200MsV4Ckm3zodJbMMSXy3haNuks5q4km3gaJpZM4Kjs9P
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 28 Oct 2016

I will try again on my normal test setup

avatar brianteeman
brianteeman - comment - 28 Oct 2016

OK retested and confirmed

IIRC this is because the content has been truncated inside an html tag. I think I remember @rdeutz looking into this exact issue on another module in the past


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12612.

avatar brianteeman brianteeman - change - 28 Oct 2016
Status New Confirmed
avatar zero-24 zero-24 - change - 29 Oct 2016
Labels Added: ?
avatar eshiol
eshiol - comment - 29 Oct 2016

I think the same of brianteeman. The 'bug' is in the function JHtmlString::truncate(allowHtml=true). The JHtmlString::truncateComplex is more reliable than the first one.

The most simple way to solve it, is using the function string.truncateComplex instead of string.truncate in the function ModArticlesCategoryHelper::truncate.

Because the bug is in the function JHtmlString::truncate, what do you think to replace JHtmlString::truncate so you automatically use JHtmlString::truncateComplex when allowHtml is true? Or, what do you think of using DOMDocument class to truncate html string?

com_finder could have the same issue.

avatar zero-24
zero-24 - comment - 29 Oct 2016

Can you send a PR with the needed changes against staging?

avatar brianteeman
brianteeman - comment - 29 Oct 2016

closed as we have a PR for testing #12625


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12612.

avatar brianteeman brianteeman - change - 29 Oct 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-10-29 19:50:21
Closed_By brianteeman
avatar brianteeman brianteeman - close - 29 Oct 2016

Add a Comment

Login with GitHub to post a comment