[#12611] - TOS incorrect to check for an article
- Fixed in Code Base
- 8 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 12611
- Diff
- brianteeman:TOS
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12573 .
Summary of Changes
The User Profile plugin has an option to add a required field for Terms of Service (TOS) - However it is only working if you also select a TOS article
This PR should enable it to work even if you do NOT select an article
Testing Instructions
Make sure you enable frontend registration
Enable the user profile plugin
Expected result
TOS field is displayed
Actual result
TOS field is not displayed
Apply this PR
TOS Field is displayed
Also check to ensure that if you select an TOS Article in the profile then the Label for the TOS is still a link
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Plugins |
@zero-24 should be ok now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12611.
| Easy | No | ⇒ | Yes |
Tested successfully
Missing commit SHA.
With the Term of Service set as Required, patch works as described.
No regression on multi-lingual and association.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12611.
I have tested this item
Tested successfully.
Has nothing to do with the PR but for me the wording is odd?
Terms of Service: *
[] Agree
[] No
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12611.
Thanks for testing- i can look at the language string in another issue
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12611.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-08 23:23:18 |
| Closed_By | ⇒ | wilsonge |
Thanks!
If that's the only problem I am happy.
Will fix soon