Feeling Lucky
?
[#12557] - $menu->params is already a Registry object.
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: staging
- # 12557
- Diff
- Bakual:FixParamMerge
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12519 .
Summary of Changes
JApplicationSite::getParams() tried to instantiate a new registry object from $menu->params, but that is already a registry object.
This PR removes that step and directly merges the component and menu params.
Testing Instructions
Set up a menu item for a component of your choice and set some parameters different from the global counterpart
Check that the menu parameter overrides the component ones.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
brianteeman
- comment
- 25 Oct 2016
Thanks for finding the solution I will test in the morning
brianteeman
- comment
- 26 Oct 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12557.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 28 Oct 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12557.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 09:34:42 |
| Closed_By | ⇒ | rdeutz |
zero-24
- | Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on cf0df7e
Back to normal.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12557.