Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12556] - Unification of method lock() in cache handlers

? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
25 Oct 2016

Pull Request for Issue #12496.

Summary of Changes

Standardization of method lock() across all storage classes:

  • APC and APCu: if there are at least one loop then set locklooped=true. Reuse stored cache which has been created a few microseconds earlier.
  • Replace 2 lines to 1 line:
-		$returning             = new stdClass;
-		$returning->locklooped = false;
+		$returning = (object) array('locklooped' => false);

Testing Instructions

Code review.

Take a look at https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/cache/controller/callback.php#L99 which can help to understand this patch.

Documentation Changes Required

None

avatar csthomas csthomas - open - 25 Oct 2016
avatar csthomas csthomas - change - 25 Oct 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2016
Category ⇒ Libraries
avatar csthomas csthomas - change - 25 Oct 2016
The description was changed
avatar csthomas csthomas - edited - 25 Oct 2016
avatar csthomas csthomas - change - 25 Oct 2016
The description was changed
avatar csthomas csthomas - edited - 25 Oct 2016
avatar csthomas csthomas - change - 25 Oct 2016
Title
…
[WIP] Fix lock method in storages
[WIP] Fix lock method in cache storages
avatar csthomas csthomas - edited - 25 Oct 2016
avatar csthomas csthomas - change - 27 Jan 2017
The description was changed
avatar csthomas csthomas - change - 27 Jan 2017
Title
…
[WIP] Fix lock method in cache storages
Unification lock method in cache handlers
avatar csthomas csthomas - edited - 27 Jan 2017
avatar csthomas csthomas - edited - 27 Jan 2017
avatar csthomas csthomas - change - 27 Jan 2017
The description was changed
avatar csthomas csthomas - edited - 27 Jan 2017
avatar csthomas csthomas - change - 30 Jan 2017
The description was changed
avatar csthomas csthomas - edited - 30 Jan 2017
avatar csthomas csthomas - change - 30 Jan 2017
The description was changed
avatar csthomas csthomas - edited - 30 Jan 2017
avatar csthomas csthomas - change - 4 Feb 2017
Title
…
Unification lock method in cache handlers
Unification of method lock() in cache handlers
avatar csthomas csthomas - change - 20 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 20 Feb 2017
avatar csthomas csthomas - change - 20 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 20 Feb 2017
avatar csthomas csthomas - change - 23 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 23 Feb 2017
avatar csthomas csthomas - change - 23 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 23 Feb 2017
avatar csthomas csthomas - change - 23 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 23 Feb 2017
avatar csthomas csthomas - change - 23 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 23 Feb 2017
avatar csthomas csthomas - change - 23 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 23 Feb 2017
avatar klas
klas - comment - 23 Feb 2017

Looks ok to me

avatar csthomas
csthomas - comment - 23 Feb 2017

Thanks, can you mark it as success at https://issues.joomla.org/tracker/joomla-cms/12556

avatar klas klas - test_item - 23 Feb 2017 - Tested successfully
avatar klas
klas - comment - 23 Feb 2017

I have tested this item ✅ successfully on 635fd22

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12556.

avatar csthomas csthomas - change - 22 Sep 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-09-22 12:26:50
Closed_By ⇒ csthomas
avatar csthomas csthomas - close - 22 Sep 2017

Add a Comment

Login with GitHub to post a comment