? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
25 Oct 2016

Pull Request for Issue # .

Summary of Changes

CodeMirror updated to the latest version. Release notes here: http://codemirror.net/doc/releases.html

Testing Instructions

Use CodeMirror, expect it to work normally.

Documentation Changes Required

Nope

avatar okonomiyaki3000 okonomiyaki3000 - open - 25 Oct 2016
avatar okonomiyaki3000 okonomiyaki3000 - change - 25 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2016
Category JavaScript External Library
avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Oct 2016

My CodeMirror builder is also updated to use only npm and not bower due to changes in the way CodeMirror is distributed. https://github.com/okonomiyaki3000/joomla-codemirror-builder

avatar brianteeman brianteeman - test_item - 25 Oct 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Oct 2016

I have tested this item successfully on b71b565

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12541.

avatar zero-24 zero-24 - change - 25 Oct 2016
Milestone Added:
avatar Twincarb Twincarb - test_item - 26 Oct 2016 - Tested successfully
avatar Twincarb
Twincarb - comment - 26 Oct 2016

I have tested this item successfully on b71b565


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12541.

avatar brianteeman brianteeman - change - 26 Oct 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 26 Oct 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12541.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 26 Oct 2016

Hmm it looks like there are conflicts can you take a look?

avatar okonomiyaki3000 okonomiyaki3000 - change - 31 Oct 2016
The description was changed
avatar okonomiyaki3000
okonomiyaki3000 - comment - 31 Oct 2016

Don't know what the conflict was all about but this should resolve it.

avatar rdeutz rdeutz - reference | 49e940c - 1 Nov 16
avatar rdeutz rdeutz - merge - 1 Nov 2016
avatar rdeutz rdeutz - close - 1 Nov 2016
avatar rdeutz rdeutz - close - 1 Nov 2016
avatar rdeutz rdeutz - merge - 1 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - close - 1 Nov 2016
avatar rdeutz rdeutz - change - 1 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-01 09:29:38
Closed_By rdeutz
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 2 Nov 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Nov 2016

mantainer remove RTC label here please

avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Labels Removed: ?
avatar dgt41
dgt41 - comment - 2 Nov 2016

@andrepereiradasilva this is already merged...

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Nov 2016

yes, so it should not have RTC label

avatar dgt41
dgt41 - comment - 2 Nov 2016

I thought the bot was taking care of that...

avatar brianteeman
brianteeman - comment - 2 Nov 2016

only on the next comment

On 2 November 2016 at 22:27, Dimitri Grammatikogianni <
notifications@github.com> wrote:

I thought the bot was taking care of that...


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12541 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TN0U_h56Ib3f6m8gbuwrfsvEgw3ks5q6Q5qgaJpZM4Kffug
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment