[#12501] - Sample data: Escape quota in json data
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: staging
- # 12501
- Diff
- csthomas:sample_escape
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Continuation of sample data files fixes started at PR #11334.
Summary of Changes
In sql sample data files escape quota for json data.
Testing Instructions
Code review or
- Create clone of git joomla or download zip
Install the latest joomla version with sample data "Learn Joomla English (GB) Sample Data"
or "Test English (GB) Sample Data"Login to backend and go to:
/administrator/index.php?option=com_menus&view=item&layout=edit&id=252You should see error.
Start new install do the same but before choose sample data replace sample data sql file with patched equivalent. Then complete installation.
Login to backend and go to: /administrator/index.php?option=com_menus&view=item&layout=edit&id=252
Now everything works as expected.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Installation Language & Strings SQL Postgresql MS SQL |
I have tested this item
On review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12501.
rdeutz
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-25 14:55:30 |
| Closed_By | ⇒ | rdeutz |
I have changed merge base from 3.6.4 to staging. Can we reopen this PR.
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-10-25 14:55:30 | ⇒ | |
| Closed_By | rdeutz | ⇒ |
done
| Labels |
Removed:
?
|
||
| Category | Installation Language & Strings SQL Postgresql MS SQL | ⇒ | SQL Installation Postgresql MS SQL |
| Title |
|
||||||
did you mean to include that installation language?
On 21 October 2016 at 16:57, Tomasz Narloch notifications@github.com
wrote:
Pull Request for repair PR #11334
#11334.
This is also related with #12460
#12460.
Summary of ChangesIn sql sample data files escape quota for json data.
Testing InstructionsCode review or
Create clone of git joomla for branch origin/3.6.3 or download zip
2.Install fresh joomla 3.6.3 with sample data "Learn Joomla English (GB)
Sample Data"
or "Test English (GB) Sample Data"
3.Login to backend and go to:
/administrator/index.php?option=com_menus&view=item&layout=edit&id=252
4.You should see error.
5.Start new install do the same but before choose sample data replace
sample data sql file with patched equivalent. Then complete installation.
6.Go to index.php/using-joomla/extensions/components/news-
feeds-component/new-feed-categories
Now everything works as expected.Documentation Changes Required
No
You can view, comment on, or merge this pull request online at:
#12501
Commit Summary
- Updated installation language files
- 3.6.4 Sample data: Escape quota in json data
File Changes
- M installation/language/hy-AM/hy-AM.ini https://github.com/joomla/joomla-cms/pull/12501/files#diff-0 (40)
- M installation/language/hy-AM/hy-AM.xml https://github.com/joomla/joomla-cms/pull/12501/files#diff-1 (4)
- M installation/sql/mysql/sample_learn.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-2 (2)
- M installation/sql/mysql/sample_testing.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-3 (2)
- M installation/sql/postgresql/sample_learn.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-4 (2)
- M installation/sql/postgresql/sample_testing.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-5 (2)
- M installation/sql/sqlazure/sample_learn.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-6 (2)
- M installation/sql/sqlazure/sample_testing.sql https://github.com/joomla/joomla-cms/pull/12501/files#diff-7 (2)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/12501.patch
- https://github.com/joomla/joomla-cms/pull/12501.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12501, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bG3S7ZLdAS448Gk889IQO6fcw8Mks5q2OD0gaJpZM4KdYaP
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I do know If I understand you correctly.
If you talk about test (point 5) then you can patch installation sql files before start installation.
There is no changes in language files.
I have tested this item
still ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12501.
| Status | New | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12501.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 09:31:38 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 5ffb6c0
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12501.