?
avatar htmgarcia
htmgarcia
21 Oct 2016

Steps to reproduce the issue

Create or edit an article, and see the icons on the right side for the dropdowns such as "Access" or "Status"

Expected result

Actual result

1
2

System information (as much as possible)

Using Joomla 3.7.x branch
Firefox browser
Mac OS

Additional comments

avatar htmgarcia htmgarcia - open - 21 Oct 2016
avatar htmgarcia htmgarcia - edited - 21 Oct 2016
avatar brianteeman
brianteeman - comment - 21 Oct 2016

Maybe I am missing something but I dont see what/where the problem is

drop

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

Confirmed using the https://github.com/joomla/joomla-cms/tree/3.7.x branch at commit 50a76bd

screen shot 2016-10-22 at 16 58 12

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

Its everywhere in that branch, not just on editing an article.
screen shot 2016-10-22 at 16 59 44

screen shot 2016-10-22 at 17 00 28

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

Also the search box in a dropdown is messed up

screen shot 2016-10-22 at 17 19 54

avatar brianteeman
brianteeman - comment - 22 Oct 2016

Rechecked current 3.7 branch with chrome, safari and firefox on osx and still can not replicate this

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

This is what I did - again, to record the video, and again, it replicated the issue.

https://www.youtube.com/watch?v=ayetRwMA6IA

avatar zero-24
zero-24 - comment - 22 Oct 2016

It is a privat video ;) can you double check that the caches are clean?

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

Video now unlisted/public

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

This is not a cache issue, my Google Chrome has cache disabled in the network panel always.

This might be a Mac Retina issue... :-) My nice new shiny iMac that only arrived yesterday is a retina...

The chosen sprite used here has this css in inspector:

@media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (min-resolution: 144dpi), only screen and (min-resolution: 1.5dppx)

This loads the /media/jui/css/chosen-sprite@2x.png sprite instead of the /media/jui/css/chosen-sprite.png sprite..

Can @brianteeman and @zero-24 and @htmgarcia confirm their mac retina or not, screen dpi, dppx...

I must admit - css is my worst area of development - I have no idea at all when it comes to CSS :)

avatar mbabker
mbabker - comment - 22 Oct 2016

I've got the same issue with my MacBook Pro. So either there's a bug with the upstream Chosen code or our implementation of it.

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

I have no issue on this page https://harvesthq.github.io/chosen/ with my hiny new mac, or my old mac

I have been to my old - non-retina - iMac in the kitchen (the new media player in there) and done the same test as in my video - and it works as expected

Therefore I conclude this is a resolution/retina issue in Joomla 3.7.dev, that is not present in the chosen demo above...

(and therefore waaaay beyond my css skills :) :) :) )

avatar zero-24 zero-24 - change - 22 Oct 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

who told you to buy mac "retina", clearly your iMac in the kitchen works better (why the hell do you have an iMac on the kitchen, to cook? :D just kidding :) )

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

now kidding aside, so this only manisfests in new macs?

avatar mbabker
mbabker - comment - 22 Oct 2016

Mine's not "new" by any means.

MacBook Pro (Retina, 13-inch, Late 2013)

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

I have an iMac in the front room, the kitchen, the bedroom, and I gave one away last week, and I have my new one on my desk (then the macbook air 11", and a 15" macbook pro... I did have an iPad mini but the daughter has "claimed" that... oh and an out of date old iPhone 6 ;-)

The joys of having to have reliable backups - of hardware as well as software

After all - no computer = no income :)

I cannot replicate it on my non-retina iMac or non-retina MacBook Pro.

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

@mbabker Dont feel bad - the iMac that arrived yesterday reports:

iMac (Retina 5k, 27-inch late 2015) 4GHz Intel Core i7
Memory 32 GB DDR3

eck? late 2015??? WTF!! This is "brand new" :-(

avatar mbabker
mbabker - comment - 22 Oct 2016

Shoulda held out a few weeks. Isn't this the time of year all the new stuff hits the market?

avatar PhilETaylor
PhilETaylor - comment - 22 Oct 2016

yup :-(

avatar dgt41
dgt41 - comment - 22 Oct 2016
avatar brianteeman brianteeman - change - 22 Oct 2016
Title
Dropdowns icons looks messy
RETINA displays only - Dropdowns icons looks messy
avatar brianteeman brianteeman - change - 22 Oct 2016
Title
Dropdowns icons looks messy
RETINA displays only - Dropdowns icons looks messy
Status New Confirmed
avatar brianteeman
brianteeman - comment - 22 Oct 2016

I have updated the title


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12500.

avatar brianteeman brianteeman - edited - 22 Oct 2016
avatar dgt41
dgt41 - comment - 22 Oct 2016

@ciar4n can you take a look at this issue?

avatar ciar4n
ciar4n - comment - 22 Oct 2016

Unable test at the moment but I'm guessing the issue is here which would only effect high pixel density displays.. https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435

If so, zooming in a couple of notches in any browser should replicate the issue? I can put in a PR to fix tomorrow.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Oct 2016

@ciar4n you nailed it, zoomed the page a lot in chrome and widonwss and was able to reproduce it

avatar dgt41
dgt41 - comment - 22 Oct 2016

@ciar4n I thought we were using the mootools icon by now for chosen...

avatar ciar4n
ciar4n - comment - 22 Oct 2016

Thank you @andrepereiradasilva .. removing that CSS should resolve it so. Alternatively I can override it in the template.css so as to keep the chosen.css to the original.

@dgt41 Yes, we are using the mootools/icomoon icon. That CSS is loading a 2x sprite for retina displays using '!important' which is overriding the CSS used to remove the sprite, hence the double icons (one the icomoon icon, the other the original sprite image).

avatar brianteeman brianteeman - change - 23 Oct 2016
Category Templates (admin)
avatar zero-24
zero-24 - comment - 23 Oct 2016

Closing as there is a PR #12528 for this please test on retina.

avatar zero-24 zero-24 - change - 23 Oct 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-10-23 15:28:35
Closed_By zero-24
avatar zero-24 zero-24 - close - 23 Oct 2016
avatar zero-24 zero-24 - close - 23 Oct 2016
avatar brianteeman
brianteeman - comment - 25 Oct 2016

This video is private

I am not saying I dont believe you are seeing this I am just saying I
cannot replicate it

On 22 October 2016 at 20:25, Phil Taylor notifications@github.com wrote:

This is what I did - again, to record the video, and again, it replicated
the issue.

https://www.youtube.com/watch?v=ayetRwMA6IA


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Rdrp2caMcHLN-_kGykab92g-HtMks5q2mMOgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 25 Oct 2016

Bingo - I can replicate it now on chrome if I "massively" zoom in

On 22 October 2016 at 22:40, Ciaran Walsh notifications@github.com wrote:

Unable test at the moment but I'm guessing the issue is here which would
only effect high pixel density displays.. https://github.com/joomla/
joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435

If so, zooming in a couple of notches in any browser should replicate the
issue? I can put in a PR to fix tomorrow.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ap3ukJtXwpNTKsNRmqm3D-PbgS1ks5q2oLDgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 25 Oct 2016

Ok so we can confirm this as an issue on retina displays then.

Can this be emulated on non retina displays

avatar brianteeman
brianteeman - comment - 25 Oct 2016

Iirc the chosen update that I did was merged into 3.6.3 but aspects of it
were overwritten in the "flat paint" pr. So I would look at those overrides
of chosen first before looking at chosen itself

avatar brianteeman
brianteeman - comment - 25 Oct 2016

I'm assuming from the comments that it will be any retina device.

avatar brianteeman
brianteeman - comment - 25 Oct 2016

I do not have a retina screen

avatar brianteeman
brianteeman - comment - 25 Oct 2016

What am I supposed to be seeing as messy?

On 21 October 2016 at 16:49, Valentín notifications@github.com wrote:

Steps to reproduce the issue

Create or edit an article, and see the icons on the right side for the
dropdowns such as "Access" or "Published"
Expected result Actual result

[image: 1]
https://cloud.githubusercontent.com/assets/4999794/19604664/dfb16996-977b-11e6-8d80-9ff6b8afcb2f.jpg
[image: 2]
https://cloud.githubusercontent.com/assets/4999794/19604669/e21de4c0-977b-11e6-8b5f-336444e441b7.jpg
System information (as much as possible)

Using Joomla 3.7.x branch
Firefox browser
Mac OS
Additional comments


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12500, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WVPizKz-uk1LGCFJEj9QnqxsRIcks5q2N8LgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar htmgarcia
htmgarcia - comment - 25 Oct 2016

If I wasn't clear, this happens with 3.7.x branch.
I have a retina display Macbook Pro (can't confirm if happens on these screens only)

avatar PhilETaylor
PhilETaylor - comment - 25 Oct 2016

This issue is resolved by #12528 - excuse the emails from @brianteeman which were delayed and arrived out of context for some reason.

avatar htmgarcia
htmgarcia - comment - 25 Oct 2016

Thanks @PhilETaylor!
Tested #12528, the issue is solved in my end.

Awesome job, everyone!

Add a Comment

Login with GitHub to post a comment