Confirmed using the https://github.com/joomla/joomla-cms/tree/3.7.x branch at commit 50a76bd
Rechecked current 3.7 branch with chrome, safari and firefox on osx and still can not replicate this
This is what I did - again, to record the video, and again, it replicated the issue.
It is a privat video ;) can you double check that the caches are clean?
Video now unlisted/public
This is not a cache issue, my Google Chrome has cache disabled in the network panel always.
This might be a Mac Retina issue... :-) My nice new shiny iMac that only arrived yesterday is a retina...
The chosen sprite used here has this css in inspector:
@media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (min-resolution: 144dpi), only screen and (min-resolution: 1.5dppx)
This loads the /media/jui/css/chosen-sprite@2x.png sprite instead of the /media/jui/css/chosen-sprite.png sprite..
Can @brianteeman and @zero-24 and @htmgarcia confirm their mac retina or not, screen dpi, dppx...
I must admit - css is my worst area of development - I have no idea at all when it comes to CSS :)
I've got the same issue with my MacBook Pro. So either there's a bug with the upstream Chosen code or our implementation of it.
I have no issue on this page https://harvesthq.github.io/chosen/ with my hiny new mac, or my old mac
I have been to my old - non-retina - iMac in the kitchen (the new media player in there) and done the same test as in my video - and it works as expected
Therefore I conclude this is a resolution/retina issue in Joomla 3.7.dev, that is not present in the chosen demo above...
(and therefore waaaay beyond my css skills :) :) :) )
Labels |
Added:
?
|
who told you to buy mac "retina", clearly your iMac in the kitchen
works better (why the hell do you have an iMac on the kitchen, to cook? :D just kidding :) )
now kidding aside, so this only manisfests in new macs?
Mine's not "new" by any means.
MacBook Pro (Retina, 13-inch, Late 2013)
I have an iMac in the front room, the kitchen, the bedroom, and I gave one away last week, and I have my new one on my desk (then the macbook air 11", and a 15" macbook pro... I did have an iPad mini but the daughter has "claimed" that... oh and an out of date old iPhone 6 ;-)
The joys of having to have reliable backups - of hardware as well as software
After all - no computer = no income :)
I cannot replicate it on my non-retina iMac or non-retina MacBook Pro.
Shoulda held out a few weeks. Isn't this the time of year all the new stuff hits the market?
yup :-(
@PhilETaylor if you were waiting one week more: http://www.macrumors.com/2016/10/22/kuo-october-2016-mac-predictions/
Title |
|
Title |
|
||||||
Status | New | ⇒ | Confirmed |
I have updated the title
Unable test at the moment but I'm guessing the issue is here which would only effect high pixel density displays.. https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435
If so, zooming in a couple of notches in any browser should replicate the issue? I can put in a PR to fix tomorrow.
Thank you @andrepereiradasilva .. removing that CSS should resolve it so. Alternatively I can override it in the template.css so as to keep the chosen.css to the original.
@dgt41 Yes, we are using the mootools/icomoon icon. That CSS is loading a 2x sprite for retina displays using '!important' which is overriding the CSS used to remove the sprite, hence the double icons (one the icomoon icon, the other the original sprite image).
Category | ⇒ | Templates (admin) |
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-23 15:28:35 |
Closed_By | ⇒ | zero-24 |
This video is private
I am not saying I dont believe you are seeing this I am just saying I
cannot replicate it
On 22 October 2016 at 20:25, Phil Taylor notifications@github.com wrote:
This is what I did - again, to record the video, and again, it replicated
the issue.https://www.youtube.com/watch?v=ayetRwMA6IA
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Rdrp2caMcHLN-_kGykab92g-HtMks5q2mMOgaJpZM4KdX4L
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Bingo - I can replicate it now on chrome if I "massively" zoom in
On 22 October 2016 at 22:40, Ciaran Walsh notifications@github.com wrote:
Unable test at the moment but I'm guessing the issue is here which would
only effect high pixel density displays.. https://github.com/joomla/
joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435If so, zooming in a couple of notches in any browser should replicate the
issue? I can put in a PR to fix tomorrow.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ap3ukJtXwpNTKsNRmqm3D-PbgS1ks5q2oLDgaJpZM4KdX4L
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
On my phone so can't test but
Ok so we can confirm this as an issue on retina displays then.
Can this be emulated on non retina displays
Iirc the chosen update that I did was merged into 3.6.3 but aspects of it
were overwritten in the "flat paint" pr. So I would look at those overrides
of chosen first before looking at chosen itself
I'm assuming from the comments that it will be any retina device.
I do not have a retina screen
What am I supposed to be seeing as messy?
On 21 October 2016 at 16:49, Valentín notifications@github.com wrote:
Steps to reproduce the issue
Create or edit an article, and see the icons on the right side for the
dropdowns such as "Access" or "Published"
Expected result Actual result[image: 1]
https://cloud.githubusercontent.com/assets/4999794/19604664/dfb16996-977b-11e6-8d80-9ff6b8afcb2f.jpg
[image: 2]
https://cloud.githubusercontent.com/assets/4999794/19604669/e21de4c0-977b-11e6-8b5f-336444e441b7.jpg
System information (as much as possible)Using Joomla 3.7.x branch
Firefox browser
Mac OS
Additional comments—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12500, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WVPizKz-uk1LGCFJEj9QnqxsRIcks5q2N8LgaJpZM4KdX4L
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
If I wasn't clear, this happens with 3.7.x branch.
I have a retina display Macbook Pro (can't confirm if happens on these screens only)
This issue is resolved by #12528 - excuse the emails from @brianteeman which were delayed and arrived out of context for some reason.
Thanks @PhilETaylor!
Tested #12528, the issue is solved in my end.
Awesome job, everyone!
Maybe I am missing something but I dont see what/where the problem is