[#12482] - Removing unnecessary code from com_search router
- Fixed in Code Base
- 22 Aug 2017
- Medium
- Build: staging
- # 12482
- Diff
- Hackwar:patch-11
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The code that is being removed does nothing. Literally. It acts on an empty array... I was thinking about removing much of the code in parse(), too, but while Joomla itself does not create such URLs, you could hand in the searchword as a first segment and that worked in the past, so we will have to keep that in until at least 4.0...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
I have tested this item
Removed code does nothing, since $segments is always array().
Searching by SEF URL index.php/search/my%20word/ still works.
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12482.
I have tested this item
Tested
Search
- Go to /index.php/search
- Search for some content
- Go to /index.php/search/<some%20content> (which is a SEF URL)
- Activate bugfix
- Go to /index.php/search
- Search for some content
- Go to /index.php/search/<some%20content> (which is a SEF URL)
Behaviour
Removed code does not change anything
Comparing the results of the test (step 1-3 and 5-7), there is no difference. The usual search as well as SEF URLs still work. The removed code does not affect anything since $segments is always an empty array.
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12482.
| Category | Front End Components | ⇒ | Front End com_search Components |
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-22 12:01:01 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Looks like this was introduce by @wilsonge here #3399