[#12481] - Removing duplicate code in com_search
- Closed
- 6 Jun 2018
- Medium
- Build: staging
- # 12481
- Diff
- Hackwar:patch-10
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
The whole check for mb_string is unnecessary. We've abstracted exactly that into the JString class, so all of that is unnecessary and should be removed. Hmm, testing instructions... Use the normal com_search with some multibyte strings and see that nothing changed, I guess...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
That would be something that we can do in 4.0, but for now I would simply remove the unnecessary code. I've been playing around with the idea of merging com_search and com_finder and been doing some work on that and most likely all of that will get rewritten for 4.0. All of that of course without any guarantees that I get enough time to work on this and get it done in time.
@franz-wohlkoenig Multi-byte strings are letters with accents like ö and ï.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12481.
since I'm working towards dropping com_search, I'm going to close this one to not waste any more time.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-06 22:20:26 |
| Closed_By | ⇒ | Hackwar |
| Category | Front End Components | ⇒ | Front End com_search Components |
maybe you can use already the Joomla\String\StringHelper