[#12437] - Make js ajax error messages more useful when using Joomla.request
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12437
- Diff
- andrepereiradasilva:ajax-error
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
There are some cases we get some strange message on ajax errors. Thsi happens when, for instance, when we use the new vannila js Joomla.request instead of the jquery ajax methods.
It seems this happens because jQuery ajax error returns different values than plain vanilla js methods do.
This PR intends to make those messages more useful in this contexts.
Testing Instructions
- Code review.
- You need to make ajax errors to test this. Example:
- Set session time to one minute so the keepalive ajax call takes one minute.
- Now edit any content in admin and leave the edit view open so keepalive keep running . add the following code in https://github.com/joomla/joomla-cms/blob/3.7.x/administrator/components/com_ajax/ajax.php#L11 to make an ajax error
$app = JFactory::getApplication();
$app->setHeader('Content-Type', 'application/json; charset=utf-8');
$app->sendHeaders();
echo jason_encode('a');
$app->close();
die();- Wait for keepalive and you will get something like this
- Now apply patch, clear browsers cache and repeat the same steps. You should get soemthing like this
### Documentation Changes Required
None.
@Fedik please review this, as you were the one that created the new Joomla.request method, and i could be missing something here.
@dgt41 please check too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12437.
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
brianteeman
- | Labels |
Removed:
?
|
||
I have tested this item
Already using it in J4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12437.
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 09:04:15 |
| Closed_By | ⇒ | rdeutz |
thanks! looks good.
I try to test in next days