Feeling Lucky
[#12422] - Clean up some Jlayouts
- Closed
- 15 Oct 2016
- Medium
- Build: 3.7.x
- # 12422
- Diff
- dgrammatiko:jlayout_cleanup
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
JLayouts should not be used to inject javascript!
Summary of Changes
Inline scripts moved to their respective files and utilise the Joomla Options!
Testing Instructions
Apply patch and check that:
- Chosen still works
- Tags still works
- drag and drop in a list view (e.g. articles) still works
B/C
Totally backwards compatible
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components Layout Libraries JavaScript |
dgt41
- comment
- 15 Oct 2016
For this particular
Ok then I will move this to J4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-15 17:03:32 |
| Closed_By | ⇒ | dgt41 |
Actually, it's not. Because people were insane enough to use layouts for JavaScript injection even when advised this was a terrible idea, if you remove the support for this you break any overrides that might exist. The fact that this practice was accepted in the first place still pisses me off, but it has to be lived with until 4.0.