Feeling Lucky
?
[#12408] - Smart search autosuggest displays code (html attributes, javascripts variables...) of the content
- Closed
- 19 May 2017
- Medium
- Build: master
- # 12408
Steps to reproduce the issue
- enable autosuggets in a smartsearch module
- in this module in front-end, in the search input, write some text
- if you write text like a CSS class name, this one will be one of the suggestions. in the image below, CSS class names are in red)
Expected result
- suggest only real content, not code
Actual result
- it suggests too much texte of article, including code (html, javascript...)
System information (as much as possible)
- Joomla 3.6.2
- all browsers
Additional comments
- maybe the solution would be in the indexing process, changing parameters in order to ignore code ?
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
4.00
mbabker
- comment
- 13 Oct 2016
Actually, I can confirm on www.joomla.org and developer.joomla.org that there are CSS classes in the search index.
| Status | New | ⇒ | Confirmed |
brianteeman
- comment
- 19 May 2017
mbabker
- comment
- 19 May 2017
Did we need to re-run the index after the 3.7 update to get that change?
mbabker
- comment
- 19 May 2017
We don't have it on a cron to do regular updates so it relies on the plugins to update the index as we make content updates on the sites. I'm running an update through the CLI for the dev site now (that one takes some time because of the JoomlaCode archive), I'll check the result when that's finished.
brianteeman
- comment
- 19 May 2017
thanks
mbabker
- comment
- 19 May 2017
The full reindex has finished on the developer site, span1 is no longer a search term there.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-19 15:57:30 |
| Closed_By | ⇒ | brianteeman |
Smart Search does remove CSS and JavaScript before parsing the text. It also ignores anything inside
<noscript>tags and anything in the<head>and it strips all HTML tags. You can see the code that does it here:https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_finder/helpers/indexer/parser/html.php
There must be something that is preventing that from happening in your case. Can you examine the HTML of the affected content items carefully and make sure that the markup is valid? Invalid markup is likely to confuse the parser and lead to leakage of class names into the index.