Switch to the hathor admin template
Go to the Admin Module Manager
You will get
500 - An error has occurred.
Layout default_batch not found.
Same issue for com_users.
All comps should be tested.
Looking into it. Either the files were being used and the docblocks were
wrong or there is a call to the files even though they're not in use
On 13 Oct 2016 11:34 a.m., "infograf768" notifications@github.com wrote:
Same issue for com_users.
All comps should be tested.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fr8dlsjjc4Qj0amkKL1J-GWY4hxks5qzgkkgaJpZM4KVpGi
.
com_users and com_modules are not working with Hathor template, otherwise I can access other components, having no issue in my local setup.
I found the issue
the Hathor default.php use
<?php echo $this->loadTemplate('batch'); ?>
Changing it to the same code as core, it is solved, i.e.
<?php // Load the batch processing form if user is allowed ?>
<?php if ($loggeduser->authorise('core.create', 'com_users')
&& $loggeduser->authorise('core.edit', 'com_users')
&& $loggeduser->authorise('core.edit.state', 'com_users')) : ?>
<?php echo JHtml::_(
'bootstrap.renderModal',
'collapseModal',
array(
'title' => JText::_('COM_USERS_BATCH_OPTIONS'),
'footer' => $this->loadTemplate('batch_footer')
),
$this->loadTemplate('batch_body')
); ?>
<?php endif;?>
Therefore we can solve the issue I think in 3.7.x
Someone makes a patch?
Yes, I have replaced this code in my local setup now I can access com_users with Hathor template. Please generate a PR so we can test it.
Thank you.
Do I have to create a new branch with reference of 3.7.x branch to create PR of this fix?
That PR was merged into staging ;) so needs to be solved in staging not 3.7!
I got it, I am asking to generate PR for above code.
If I want to generate PR for joomla 3.7-dev, Do I have to create new branch with reference of 3.7.x branch instead of staging?
the patch should also inlude the part for modules
@RonakParmar
if you do not feel confident, will make the pr a bit later.
Title |
|
Title |
|
I know how to make a PR, just want to know for 3.7.x which branch I have to refer.
It is okay if someone else will generate PR for this fix, and I'll test that PR. :)
Title |
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-14 05:13:40 |
Closed_By | ⇒ | infograf768 |
Closing as we have a PR #12412
Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/12407
@RonakParmar @brianteeman @wilsonge
Thanks for testing
This was caused by my PR #11762