As you are deleting a file can you add that to the list of files to be
removed when a user upgrades please

On 6 October 2016 at 15:26, Dimitri Grammatikogianni <
notifications@github.com> wrote:

Pull Request for Issue # .
Summary of Changes

• Drag and drop required jQuery (which wasn't really loaded by the plugin) which was WRONG. Blame me for that!
• New tinymce-init relied on jQuery (again no jQuery load call)
• jModalClose relied on document.onreadystatechange which was broken by the core.js with the new Joomla.Options.

Testing Instructions

Go to Admin -> configuration -> articles ->editing layouts and disable
(hide) Frontend Images and Links.
Try to edit an article in the front end and use any of the xtd-buttons
that have a modal (e.g. menu)
The modal will not close when selecting a menu.

Apply this patch and retry

Also try to drag and drop an image to tinymce area, the progress bar
should appear and when complete disappear.
Documentation Changes Required

None

@Fedik https://github.com/Fedik you had a line options =
jQuery.extend({}, options); in tiny-init.js. Is that required? Do we have
to replicate this with native JS?

@wilsonge https://github.com/wilsonge @rdeutz

https://github.com/rdeutz this is release-blocker IMHO

You can view, comment on, or merge this pull request online at:

#12324
Commit Summary

• drop jquery, fix jModalClose()

File Changes

• D media/editors/tinymce/js/tinymce-init.min.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-0 (1)
• M media/editors/tinymce/plugins/jdragdrop/plugin.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-1 (11)
• M media/editors/tinymce/plugins/jdragdrop/plugin.min.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-2 (2)
• M media/system/js/tiny-close.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-3 (39)
• M media/system/js/tiny-close.min.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-4 (2)
• R media/system/js/tinymce-init.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-5 (27)
• A media/system/js/tinymce-init.min.js https://github.com/joomla/joomla-cms/pull/12324/files#diff-6 (1)
• M plugins/editors/tinymce/tinymce.php https://github.com/joomla/joomla-cms/pull/12324/files#diff-7 (5)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/12324.patch
• https://github.com/joomla/joomla-cms/pull/12324.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12324, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cukVKDJeznVnAZjAlt5iu1sgHR2ks5qxQUbgaJpZM4KQAXC
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@brianteeman these files were introduced in 3.7, so not avail in previous versions.

EDIT: Also not deleted just moved to media/system/js, but GitHub doesn't really get that...

ok

On 6 October 2016 at 15:30, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman these files were introduced
in 3.7, so not avail in previous versions

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12324 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fsGrIw9X8D0Nc_0_Dy5vh5C6bhaks5qxQXygaJpZM4KQAXC
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@dgt41 In Joomla 3.7 jQuery.extend({}, options); can be replaced to Joomla.extend({}, options)

@Fedik new toys, yay! Ok fixed that

Modals are now closing OK with this PR.

I have tested this item ✅ successfully on 21274b3

looks go to me. Thanks @dgt41

I have tested this item ✅ successfully on 21274b3

RTC

Removed RTC label

@dgt41
As discussed in chat, just a reminder: this is now broken since I guess some other merges in 3.7.
TypeError: window.parent.jModalClose is not a function