? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
4 Oct 2016

Pull Request for Issue # .

Summary of Changes

Updated CodeMirror to 5.19. Also, starting with this version, All uglified js files are being processed with optimize-js which promises faster code execution in most javscript engines.

Testing Instructions

Just use CodeMirror as usual. Expect it to work normally.

Documentation Changes Required

Nope

avatar okonomiyaki3000 okonomiyaki3000 - open - 4 Oct 2016
avatar okonomiyaki3000 okonomiyaki3000 - change - 4 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2016
Category JavaScript External Library
avatar brianteeman brianteeman - test_item - 5 Oct 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Oct 2016

I have tested this item successfully on 5e6919b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12300.

avatar zero-24 zero-24 - test_item - 5 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 5 Oct 2016

I have tested this item successfully on 5e6919b

Thanks ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12300.

avatar zero-24 zero-24 - change - 5 Oct 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Oct 2016

RTC. Thanks! This is ready for 3.7.x ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12300.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 13 Oct 2016

when it is for 3.7 should we change the base branch?

avatar zero-24
zero-24 - comment - 14 Oct 2016

First we need to merge staging into 3.7.x else we break this pr if we change the base

avatar zero-24 zero-24 - change - 16 Oct 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-10-16 14:29:20
Closed_By zero-24
avatar zero-24 zero-24 - close - 16 Oct 2016
avatar zero-24 zero-24 - merge - 16 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Oct 2016
avatar zero-24
zero-24 - comment - 16 Oct 2016

Thanks. It looks like staging gets merged into 3.7.x at some time ?

avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment