[#12290] - Cleanups, fixes and a bit of optimizations for site/components batch #1
- Fixed in Code Base
- 18 Dec 2016
- Medium
- Build: staging
- # 12290
- Diff
- frankmayer:site-com_ajax-com_banners-com_config
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
- com_ajax
- com_banners
- com_config
Note: This is a single commit bundling all types of changes, since PR #12261 which had detailed commits, was rejected as a whole
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
Should I revert the query change, so that this PR can go through? It's a pity that the other changes are held back because of the query.
I could then do another PR with the query change, if there is a final decision on that.
you should not mix Code Style, bug fixes and other changes in one PR. A PR should have one topic and nothing more that makes it easier to test and it gets merged faster
Yes, the problem with that is, that for those kinds of changes, there would probably be need for hundreds of PRs (and therefore branches) if those are not somehow grouped to digestible chunks, which I tried to do with this set of PRs.
| Category | Front End Components | ⇒ | Front End com_ajax com_banners com_config Components |
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12290.
| Category | Front End Components com_ajax com_banners com_config | ⇒ | Front End com_banners com_config Components |
Fixed some conflicts that had occurred in the meantime.
Having merged the changes of above referenced PR's made this PR lighter and easier to test.
It is essentially ready to be merged, when the team finds the time and PR is OK.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-18 10:55:14 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
cpfeifer
-
This looks fine on review other than the query which I straight skipped because I need to go do some reading up on