? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
3 Oct 2016

Pull Request for Issue #8610 .

Summary of Changes

Mod article news events now have their own context which allows content plugins to listen to the events

Documentation Changes Required

The new context for the plugins which means extensions wishing to trigger on this context MUST update the array of possible values

TODO

  1. Check our content modules to see if they also need their own unique plugin names
  2. Check our content plugins so that they are still executed in the new context
avatar wilsonge wilsonge - open - 3 Oct 2016
avatar wilsonge wilsonge - change - 3 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Category Modules Front End
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 3 Oct 2016
Milestone Added:
avatar wilsonge wilsonge - change - 3 Oct 2016
The description was changed
avatar wilsonge wilsonge - edited - 3 Oct 2016
avatar zero-24 zero-24 - change - 3 Oct 2016
The description was changed
Labels Added: ?
avatar zero-24
zero-24 - comment - 3 Oct 2016

@wilsonge would it not be better to use the new plugin system as we are against 4.0? btw. Did you expect to add a joomla brache on upstream?

avatar piotr-cz
piotr-cz - comment - 3 Oct 2016

Since this is a B/C anyway, I'd suggest constructing context other way around: content type.extension
Just like composer packages have vendor/library name

avatar wilsonge
wilsonge - comment - 3 Oct 2016

That assumes components only have one content type which isn't necessarily the case. For example in the front end com_content has 3 - com_content.categories, com_content.category and com_content.article (and maybe one more for the form - i don't know off the top of my head). If we are doing that (which I don't really agree with btw) then it should be in a separate PR over all components - not as part of this!

avatar piotr-cz
piotr-cz - comment - 4 Oct 2016

Current proposal (mod_articles_news.content) puts more stress on the extension then on the item type.

At this moment when I'm writing a content plugin such as plg_content_joomlarrssb I'm deciding if to process the item by checking it's type from first string before the dot.

I think that the context should not differ per extension but if it really has to, I'd send it as new parameter to keep B/C or as in comment #8610 (comment) by @ggppdk to use com_content.article@mod_articles_news.

Anyway this may be a serious B/C change and probably all 3p content plugins won't work anymore.

ps:
I agree that in case of content we should differentiate between categories and articles, but I don't think we should make difference between articles, featured and archived at the context level.
You can access item properties and check for these attributes anyway.

avatar wilsonge
wilsonge - comment - 4 Oct 2016

Ultimately this is because we really ought to trigger a lot of these plugin events in the model rather than the view. Of course so many plugins give back html that this is pretty much impossible these days....

avatar brianteeman brianteeman - close - 20 Oct 2016
avatar wilsonge wilsonge - close - 20 Oct 2016
avatar wilsonge
wilsonge - comment - 20 Oct 2016

Closing this for now to move it back into one of my branches so i can finish work on it

avatar wilsonge wilsonge - change - 20 Oct 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-10-20 09:55:48
Closed_By wilsonge
avatar wilsonge wilsonge - close - 20 Oct 2016
avatar wilsonge wilsonge - head_ref_deleted - 20 Oct 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Nov 2016

@brianteeman @zero-24 please remove the milestone here since this is closed

avatar brianteeman brianteeman - change - 5 Nov 2016
The description was changed
avatar brianteeman brianteeman - change - 5 Nov 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment