Feeling Lucky
?
[#12270] - [3.7] Admin - Simplify instantiation of Registry
- Fixed in Code Base
- 3 Oct 2016
- Medium
- Build: 3.7.x
- # 12270
- Diff
- mbabker:simplify-registry
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The Registry object supports constructor injection of data objects (arrays, objects, and strings). So in places we're creating a registry then loading the data source, we can simplify this to just load it through the constructor.
Testing Instructions
In the admin app, functions using the Registry object continue working as expected.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Tags Templates (admin) |
| Labels |
Added:
?
|
||
andrepereiradasilva
- comment
- 3 Oct 2016
I have tested this item
code review
applied patch, navigated a little in the backend and all seems fine
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12270.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 3 Oct 2016
RTC. Thanks
cc: @rdeutz
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12270.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-03 21:57:15 |
| Closed_By | ⇒ | wilsonge |
brianteeman
- comment
- 9 Oct 2016
Removed RTC label
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on da86de4
?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12270.