[#12242] - Replace Platform version numbers in libraries/legacy
- Fixed in Code Base
- 29 Oct 2016
- Medium
- Build: staging
- # 12242
- Diff
- mbabker:legacy-platform-versions
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Replace Platform version numbers in the
libraries/legacydirectory with CMS version numbers - Make
@deprecatedtag change to match new questionable structure
Testing Instructions
Review
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
I have tested this item
On review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12242.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12242.
| Labels |
Added:
?
|
||
rdeutz
- | Milestone |
Added: |
||
Done
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-29 14:48:56 |
| Closed_By | ⇒ | rdeutz |
@mbabker
Fatal error when editing module and anyhting else as we have 41 instances of it:
( ! ) Fatal error: Access level to ModulesViewModule::$form must be public (as in class JViewLegacy) in ROOT/administrator/components/com_modules/views/module/view.html.php on line 18
You added
/**
* A form object
*
* @var JForm
* @since 3.2
*/
public $form;
and the module view.html.php has
protected $form;
as most of the views
( ! ) Fatal error: Access level to ContentViewArticle::$form must be public (as in class JViewLegacy) in /Applications/MAMP/htdocs/trunkgitnew/administrator/components/com_content/views/article/view.html.php on line 18
:)
| Labels |
Removed:
?
|
||
I'm getting sick and freakin' tired of this code stack being so reliant on undeclared class variables. Issue a PR to remove it. This is outrageous.
I have tested this item✅ successfully on bc64649
Code review.
Seems fine to me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12242.