? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Oct 2016

Pull Request for
https://groups.google.com/d/msg/joomla-dev-cms/kIl2dmUEw_s/bj44KpnwCQAJ

in accordance with PLT decision th t the number show the from not the in version

avatar brianteeman brianteeman - open - 1 Oct 2016
avatar brianteeman brianteeman - change - 1 Oct 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2016
Category Administration Components Media Manager Tags
avatar mbabker
mbabker - comment - 1 Oct 2016

I'd almost call this worse because it gives the impression we deprecated everything at 3.7.

avatar brianteeman
brianteeman - comment - 1 Oct 2016

No comment - I just did what was requested

As I commented on the list it is totally inpractical to go back in time and
check when each of these were individually deprecated
Also note that a large % of them have already been removed in the j4 branch

avatar mbabker
mbabker - comment - 1 Oct 2016

I'm still not convinced a major B/C break of the coding standards is acceptable either but I'd also say a mass replacement changing to read as though the entire API was deprecated in this next version isn't the best move.

avatar brianteeman
brianteeman - comment - 1 Oct 2016

Its only the items that were marked deprecated 4.0 that have been changed -
not the entire api

On 1 October 2016 at 15:40, Michael Babker notifications@github.com wrote:

I'm still not convinced a major B/C break of the coding standards is
acceptable either but I'd also say a mass replacement changing to read as
though the entire API was deprecated in this next version isn't the best
move.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12241 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YJbKIfJ7SaOsxsPKf_nlqc0SVAoks5qvnDzgaJpZM4KLxAw
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 1 Oct 2016

Right, but using the new standard, it reads as though all of the deprecated API was deprecated in 3.7, which is a complete lie. And yes I get the whole "it's too much work to go through history to find the correct values" argument. But honestly I'd say either leave the current tags alone (as you said a lot of them go away in 4.0 anyway) or change them to the correct values (which is a majorly inefficient use of everyone's time).

I'd still like clarification from PLT if this is yet another CMS only decision or if it applies to all code because I'll too have to waste a day correcting the Framework.

avatar Bakual
Bakual - comment - 1 Oct 2016

I honestly hoped this was a joke but apparently it's indeed a PLT decision to not follow the phpDocumentar manual with this. Looks wrong to me but in the end it doesn't matter much.
If there is a deprecated tag present in a current version, it can be removed at next major release, no matter what the version number says.

avatar brianteeman
brianteeman - comment - 1 Oct 2016

Closed as it was a waste of my time and I'm certainly not going through every pr to find the exact version. I will leave that for some other mug.

avatar brianteeman brianteeman - change - 1 Oct 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-10-01 21:07:35
Closed_By brianteeman
avatar brianteeman brianteeman - close - 1 Oct 2016
avatar wilsonge
wilsonge - comment - 1 Oct 2016

PSR-5 is the effectively the next version of the php documentor standards written by the same guy... ok it's not a approved standard but it's not exactly from some obscure source..

Add a Comment

Login with GitHub to post a comment