[#12179] - [4.0] Remove exception catching in JMail
- Closed
- 2 Jun 2018
- Medium
- Build: 4.0-dev
- # 12179
- Diff
- mbabker:mail-exceptions
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove the internal handling of exceptions thrown by the PHPMailer API in JMail. This changes the behavior so that when exception throwing is turned on (default yes) exceptions will be thrown by the API and when disabled boolean values are returned. This is consistent with the parent API's behavior.
Testing Instructions
Mail sending still functions as intended. When exception handling is disabled boolean values are still handled.
Note: We probably need to turn on exception handling in core's mail sending functions otherwise these will bubble to something catching the base Exception class or the global handler which triggers the error page.
Documentation Changes Required
Error handling behavior changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
zero-24
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Are we going anywhere with this?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12179.
Rebased, I'm now at a "take it or leave it" spot with this one. Got enough architecture work on my hands to really care much about keeping up with this one.
We need to add some basic exception handling around the places we are using our mailer. Having user registration, for example, fail all the way to our exception handler page because a mail couldn't be sent cannot be correct behaviour. Of course I approve us removing these - but we cannot merge this as is right now.
If someone else wants to take this on, have at it. Otherwise, I'm overbooked and getting people to deal with architecture related stuff seems difficult.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-02 01:14:29 |
| Closed_By | ⇒ | mbabker |
@mbabker,
We have picked up this issue and are working one handling all the Exceptions in the places that use the mailer.
At the moment we handle them like this:
However we were wondering if the way we are handling them is optimal or if there is a better way to deal with them, and also if the exception categories/types are appropriate.
can't be reopened as Branch is deleted.
It is not to be re-opened but asking for feedback.
Looks fine for now
I'm going to leave this here for now so we can work out what actually needs exception catching in the API around email sending