[#12173] - View property cleanup
- Fixed in Code Base
- 21 Jan 2017
- Medium
- Build: 4.0-dev
- # 12173
- Diff
- wilsonge:view-property-cleanup
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
This adds view properties and cleans up doc blocks for said properties across all our core components. This is the one place we have been really really bad at keeping things in check in recent years
Testing Instructions
You need to test every single view in Joomla still works as before. The only real way this will break something is if a view property should have been public instead of protected which would give a fatal error. So it will be really obvious if something is wrong.
Further Notes
All new PR's that add view properties MUST now create a view property with it
I currently have skipped 1 view in Joomla Update and the Media Manager component because I honestly had no clue what half the properties actually did
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Media Manager |
| Labels |
Added:
?
|
||
| Category | Administration Components com_media | ⇒ | Administration com_categories com_checkin com_contact com_content com_contenthistory com_cpanel com_finder com_installer com_joomlaupdate com_languages com_media com_menus Components |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-21 16:16:11 |
| Closed_By | ⇒ | wilsonge |