Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12172] - Add missing break in switch statement

? Pending

User tests: Successful: Unsuccessful:

avatar n9iels
n9iels
25 Sep 2016

Summary of Changes

This PR adds a missing break; to a switch statement in the calendar field. Very small change

Testing Instructions

I see no good way to test this, just verify that the calendar field is still working :)

4d3735d 25 Sep 2016 avatar n9iels CS
avatar n9iels n9iels - open - 25 Sep 2016
avatar n9iels n9iels - change - 25 Sep 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2016
Category ⇒ Libraries
avatar Bakual
Bakual - comment - 25 Sep 2016

I think that break is missing by design.
Otherwise the value is only cast to (int) but not written to $this->$name. So it pretty much doesn't do anything after your PR ?

avatar n9iels
n9iels - comment - 25 Sep 2016

@Bakual I'm Sorry, made this PR a little bit too fast ? You're absolutely right :)

I close this PR now

avatar n9iels n9iels - change - 25 Sep 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-09-25 20:01:35
Closed_By ⇒ n9iels
avatar n9iels n9iels - close - 25 Sep 2016

Add a Comment

Login with GitHub to post a comment