? ? Failure

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 Sep 2016

The Title of the configuration view Plugin: Options is different (singular) from the Plugins title in the list of Components on the Global Configuration page.

configure-components-plural-single-plugin-both-before

Testing Instructions

Before the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Plugins (= plural).
The Title " Plugin: Options" is singular.

configure-components-plural-single-plugin-before

After the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Plugins.
The Title " Plugins: Options" is plural too.

configure-components-plural-single-plugin-after

avatar pe7er pe7er - open - 20 Sep 2016
avatar pe7er pe7er - change - 20 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Category Language & Strings Administration
avatar brianteeman
brianteeman - comment - 20 Sep 2016

techinicaly it is wrong to say plugins
this is not the options for plugins(plural)
this is the option for the component (singular) but the component is called
plugins

So for consistency I am ok with this change even if it actually wrong

On 20 September 2016 at 13:02, Peter Martin notifications@github.com
wrote:

The Title of the configuration view Plugin: Options is different
(singular) from the Plugins title in the list of Components on the
Global Configuration page.

[image: configure-components-plural-single-plugin-both-before]
https://cloud.githubusercontent.com/assets/1217850/18665998/07b22b16-7f2a-11e6-80c7-cf89fdbf8623.png
Testing Instructions Before the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Plugins (= plural).
The Title " Plugin: Options" is singular.

[image: configure-components-plural-single-plugin-before]
https://cloud.githubusercontent.com/assets/1217850/18665999/07b2dd5e-7f2a-11e6-90a8-230355fd1dcc.png
After the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Plugins.
The Title " Plugins: Options" is plural too.

[image: configure-components-plural-single-plugin-after]

https://cloud.githubusercontent.com/assets/1217850/18665997/07ae6be8-7f2a-11e6-8c0a-46b14d4ab494.png

You can view, comment on, or merge this pull request online at:

#12104
Commit Summary

  • Config Plugins - changed title: Plugin: Options

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12104, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WJ0uvYT-FJGrr7XzuiEaJ2Fu2Khks5qr68_gaJpZM4KBcVA
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar MATsxm MATsxm - test_item - 20 Sep 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 20 Sep 2016

I have tested this item successfully on 0bd13d1

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12104.

avatar RonakParmar RonakParmar - test_item - 21 Sep 2016 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 21 Sep 2016

I have tested this item successfully on 0bd13d1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12104.

avatar brianteeman brianteeman - change - 21 Sep 2016
Status Pending Needs Review
Labels
avatar brianteeman
brianteeman - comment - 21 Sep 2016

I am going to set this and the related PR to needs review so they are not merged until we make a decision on them all as I am not convinced it is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12104.

avatar pe7er
pe7er - comment - 21 Sep 2016

If every Options tab starts with a blue bar with some information, the UI for Options will be consistently the same on all Option Tabs. That way an admin has an extra visual pointer (besides the "Options" in the Page Title) that they are on the Options page.

avatar brianteeman
brianteeman - comment - 21 Sep 2016

I don't agree in adding help text if it has no meaning or value. That has
the effect of users just ignoring it. It should only exist if it is
required information

avatar rdeutz rdeutz - change - 27 May 2017
The description was changed
avatar rdeutz rdeutz - change - 26 Oct 2017
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2017-10-26 19:03:42
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Oct 2017

Add a Comment

Login with GitHub to post a comment