? ? Failure

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
20 Sep 2016

The Title of the configuration view Template: Options is different (singular) from the Templates title in the list of Components on the Global Configuration page.

configure-components-plural-single-templates-both-before

Testing Instructions

Before the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Templates (= plural).
The Title " Template: Options" is singular.

configure-components-plural-single-templates-before

After the PR:

Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Templates.
The Title " Templates: Options" is plural too.

configure-components-plural-single-templates-after

avatar pe7er pe7er - open - 20 Sep 2016
avatar pe7er pe7er - change - 20 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Category Language & Strings Administration
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Labels Added: ? ?
avatar jeckodevelopment jeckodevelopment - test_item - 20 Sep 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 20 Sep 2016

I have tested this item successfully on 28ccec4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12103.

avatar brianteeman
brianteeman - comment - 20 Sep 2016

grammatically this is an edge case if it is correct or not. But for
consistency I am ok with it

On 20 September 2016 at 12:38, Luca Marzo notifications@github.com wrote:

I have tested this item successfully on 28ccec4

28ccec4

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/12103
https://issues.joomla.org/tracker/joomla-cms/12103.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12103 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZZvJZ_9a-cnI2X10CknrHa_z2ZZks5qr6mBgaJpZM4KBaxm
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24 zero-24 - test_item - 20 Sep 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 20 Sep 2016

I have tested this item successfully on 28ccec4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12103.

avatar jeckodevelopment jeckodevelopment - change - 20 Sep 2016
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 20 Sep 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12103.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - change - 20 Sep 2016
Milestone Added:
avatar zero-24 zero-24 - change - 20 Sep 2016
Milestone Removed:
avatar zero-24 zero-24 - change - 20 Sep 2016
Milestone
avatar zero-24 zero-24 - change - 20 Sep 2016
Milestone
avatar zero-24 zero-24 - change - 20 Sep 2016
Milestone Removed:
avatar brianteeman
brianteeman - comment - 21 Sep 2016

I am going to set this and the related PR to needs review so they are not merged until we make a decision on them all as I am not convinced it is correct.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12103.

avatar brianteeman brianteeman - change - 21 Sep 2016
Status Ready to Commit Needs Review
Labels
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Added:
avatar brianteeman brianteeman - change - 17 Oct 2016
Milestone Removed:
avatar rdeutz
rdeutz - comment - 18 Oct 2016

@brianteeman still in needs review? And if what is the case?

avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2016
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 18 Oct 2016

The options page is for the component and not for all templates - so writing "templates: options" is not correct as that would imply they are settings for all the templates
the problem with the core is that we should therefore be using the name of the component here
But sometimes the component has a plural name eg com_templates and sometimes it has a singular name eg com_newsfeed

So at the end of the day I feel that on the options page we should always use the singular. as it refers to the settings of the singular item - a component and not a plural - the settings for all the items created/managed by the component

if anything the actual 100% correct string would be com_templates: options but thats not friendly
and changing to Templates: Options is just not correct

sorry for the rant - this applies to all the similar PRs

avatar brianteeman
brianteeman - comment - 18 Oct 2016

The options page is for the component and not for all templates

Even that isnt true for the options on some components. Which is why for example articles is articles:options (plural)

It could even be argued that there is a missing apostrophe as they are the options of the component which is a possesive

avatar rdeutz rdeutz - change - 17 Apr 2017
Milestone Added:
avatar rdeutz rdeutz - change - 17 Apr 2017
Milestone Removed:
avatar zero-24 zero-24 - change - 12 May 2017
Milestone Removed:
avatar zero-24 zero-24 - change - 12 May 2017
Milestone Added:
avatar zero-24 zero-24 - change - 12 May 2017
Milestone Added:
avatar zero-24 zero-24 - change - 12 May 2017
Milestone Removed:
avatar rdeutz rdeutz - change - 18 May 2017
Milestone Removed:
avatar rdeutz rdeutz - change - 18 May 2017
Milestone Added:
avatar rdeutz rdeutz - change - 18 May 2017
Milestone Added:
avatar rdeutz rdeutz - change - 18 May 2017
Milestone Removed:
avatar mbabker
mbabker - comment - 30 May 2017

What's the deal with this and its companion PRs?

avatar brianteeman
brianteeman - comment - 30 May 2017

they are waiting a decision - I expressed my view above

avatar rdeutz
rdeutz - comment - 30 May 2017

I would say singular both in title and sidebar, maybe easier to close the PR and start from scratch

avatar brianteeman
brianteeman - comment - 30 May 2017

why not ask the en-GB working group

avatar rdeutz
rdeutz - comment - 30 May 2017

@brianteeman stop making sense :-)

avatar rdeutz rdeutz - change - 14 Jun 2017
Milestone Removed:
avatar rdeutz rdeutz - change - 14 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 14 Jun 2017
Milestone Added:
avatar rdeutz rdeutz - change - 14 Jun 2017
Milestone Removed:
avatar rdeutz rdeutz - change - 11 Jul 2017
Milestone Added:
avatar rdeutz rdeutz - change - 11 Jul 2017
Milestone Removed:
avatar korneliusz401 korneliusz401 - test_item - 9 Aug 2017 - Tested successfully
avatar korneliusz401
korneliusz401 - comment - 9 Aug 2017

I have tested this item successfully on 28ccec4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12103.

avatar gwsdesk
gwsdesk - comment - 19 Sep 2017

I happen to agree with @brianteeman on this one. His explanation makes very much sense me think

avatar rdeutz rdeutz - change - 26 Oct 2017
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2017-10-26 12:53:16
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Oct 2017

Add a Comment

Login with GitHub to post a comment