[#12101] - Config Redirects - changed title: Redirect: Options
- Closed
- 26 Oct 2017
- Medium
- Build: staging
- # 12101
- Diff
- pe7er:configure-components-name-redirects
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The Title of the configuration view Redirect: Options is different (singular) from the Redirects title in the list of Components on the Global Configuration page.
Testing Instructions
Before the PR:
Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Redirects (= plural).
The Title " Redirect: Options" is singular.
After the PR:
Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: Redirects.
The Title " Redirects: Options" is plural too.
| Labels |
Added:
?
?
|
||
Technically I think it should be redirect because that is the name of the
component but for consistency I am ok with this change
On 20 September 2016 at 12:35, Luca Marzo notifications@github.com wrote:
I have tested this item
✅ successfully on 31bd12831bd128
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/12101
https://issues.joomla.org/tracker/joomla-cms/12101.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12101 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bORNsTst-fXNWFm0Gkr32gAe1G0ks5qr6j1gaJpZM4KBaYn
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12101.
| Category | ⇒ | Administration Language & Strings |
| Status | New | ⇒ | Ready to Commit |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone | |||
| Milestone | |||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Needs Review |
| Labels | |||
I am going to set this and the related PR to needs review so they are not merged until we make a decision on them all as I am not convinced it is correct.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12101.
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@chrisdavenport could you put that on the agenda of the en-GB team for a decision, this is pending for such a long time. I will set the milestone to 3.8 for now and would say we close these PR if till the release date of 3.8 no decision is made.
#12103 same question @chrisdavenport
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12101.
Reminder for @chrisdavenport of @rdeutz Comment above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12101.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-26 12:53:21 |
| Closed_By | ⇒ | rdeutz |
I closed them as well, thanks.
I have tested this item✅ successfully on 31bd128
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12101.