[#12100] - Config News Feeds - changed title: News Feed: Options
- Closed
- 26 Oct 2017
- Medium
- Build: staging
- # 12100
- Diff
- pe7er:configure-components-name-newsfeeds
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The Title of the configuration view News Feed: Options is different (singular) from the News Feeds title in the list of Components on the Global Configuration page.
Testing Instructions
Before the PR:
Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: News Feeds (= plural).
The Title " News Feed: Options" is singular.
After the PR:
Backend: System > Global Configuration > under COMPONENT (left menu)
Click on Configure Menu Title: News Feeds.
The Title " News Feeds: Options" is plural too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Administration |
| Labels |
Added:
?
?
|
||
technically it is wrong to say News Feeds
this is not the options for News Feeds(plural)
this is the option for the component (singular) but the component is called newsfeeds
So for consistency I am ok with this change even if it actually wrong
I have tested this item
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12100.
| Status | Pending | ⇒ | Needs Review |
| Labels | |||
I am going to set this and the related PR to needs review so they are not merged until we make a decision on them all as I am not convinced it is correct.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12100.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12100.
@brianteeman what do we need to move forward with this, there are some others with the same state?
I havent changed my view from that stated before
Didn't expect that you have changed your view :-)
I am going to set this and the related PR to needs review so they are not merged until we make a decision on them all as I am not convinced it is correct.
The question is who is "WE"
not me - I guess its the maintainers role as there is no en-gb group anymore
we did discuss this before (but we are both old and forget things)
The main problem is that by making them consistent you are also making some
of them wrong. Sometimes the option is for the component itself eg
com_modules and sometimes the option is for the items in the component eg
com_content and as we have a mix of singular and plural for the component
names you can't make it correct. My feeling is that the change doesn't
introduce any benefits and perhaps introduces more inconsistencies and
confusion instead of removing them
On 16 Mar 2017 9:39 a.m., "Brian Teeman" notifications@github.com wrote:
not me - I guess its the maintainers role as there is no en-gb group anymore
we did discuss this before (but we are both old and forget things)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12100 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ex5Z4NCZ2ctneyqllqVX6N3Zn_fks5rmQNKgaJpZM4KBZeL
.
I think it should be correct and consistent in that what we show to the user, I don't care if this matches to the (technical) component name. I think some native en-gb speaker should make a decision, if I use the right English grammar it is more per accident :-)
by accident not per accident :)
As I said :-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12100.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-26 19:03:48 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 7bdef9b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12100.