[#12077] - Label - Mass Mail Users
- Closed
- 20 Sep 2016
- Medium
- Build: staging
- # 12077
- Diff
- pe7er:label-mass-mail-users
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
The language label "Mass Mail Users" in the back-end menu Users is not consistent with the Component Title label "Mass Mail".
Summary of Changes
This PR changes the language label to "Mass Mail Users" to "Mass Mail" because the title of that view
administrator/index.php?option=com_users&view=mail
shows it as "Mass Mail"
Testing Instructions
Before the PR:
backend: Users >
last menu item: Mass Mail Users
After the PR:
backend: Users >
last menu item: Mass Mail
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Language & Strings Administration |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12077.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
I agree it is not consistent but I am not convinced this PR is changing the correct one. Personally I would have changed the title to match the menu as it is more accurate.
@jeckodevelopment please do not make changes like this RTC without comment by at least one native english speaker
ok @brianteeman
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
@brianteeman @jeckodevelopment Thank you for testing & looking into this issue!
Yeah, I thought about keeping the menu title and changing the Title in the view,
but as a lot of menus have been shortened (Article Manager -> Articles, etc) recently (which I like),
and because the "Mass Mail (Users)" menu is under "Users" just like "Manage (Users)",
I created the PR like this.
An alternative PR to make the Menu Item + Title on the view consistent: #12084
Yes, please do. If a lot of other people would come up with arguments for solving it this way, then we could always open the PR again :-)
Ehm, I'll close it myself :-)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-20 07:34:54 |
| Closed_By | ⇒ | pe7er |
I have tested this item✅ successfully on 542f8cb
Agree looks better
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12077.