? ? ? Pending

User tests: Successful: Unsuccessful:

avatar MATsxm
MATsxm
19 Sep 2016

Minor and easy fix

  • Turned the JED link to https
  • Minor few fixes on proper use of the trademarked name of Joomla!

Testing Instructions

on code review

avatar MATsxm MATsxm - open - 19 Sep 2016
avatar MATsxm MATsxm - change - 19 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Category Repository
avatar zero-24 zero-24 - change - 19 Sep 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 19 Sep 2016

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12076.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar MATsxm
MATsxm - comment - 19 Sep 2016

Oooops ? too fast @zero-24
.txt has also to be updated...
do I have to make a new one or you can merge even if this is closed?

avatar zero-24
zero-24 - comment - 19 Sep 2016

This is not closed. Everything is good here :)

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Sep 2016

all this files have extension.joomla.org URL

README.md
README.txt

administrator/language/en-GB/en-GB.com_installer.ini

administrator/templates/hathor/html/mod_menu/default_enabled.php
administrator/modules/mod_menu/tmpl/default_enabled.php

installation/sql/mysql/sample_testing.sql
installation/sql/mysql/sample_learn.sql
installation/sql/mysql/sample_blog.sql
installation/sql/postgresql/sample_testing.sql
installation/sql/postgresql/sample_learn.sql
installation/sql/postgresql/sample_blog.sql
installation/sql/sqlazure/sample_testing.sql
installation/sql/sqlazure/sample_learn.sql
installation/sql/sqlazure/sample_blog.sql
installation/INSTALL

tests/unit/stubs/database/jos_ucm_content.csv
tests/unit/stubs/database/jos_content.csv
tests/unit/stubs/database/jos_categories.csv
tests/unit/stubs/database/jos_finder_links.csv

So i think you should changed in all of them

avatar MATsxm
MATsxm - comment - 19 Sep 2016

if this can wait for tomorrow... I will ?

Thanks

avatar zero-24 zero-24 - change - 19 Sep 2016
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 19 Sep 2016

Moving to pending until than


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12076.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Category Repository Repository Language & Strings Administration
avatar MATsxm MATsxm - change - 19 Sep 2016
Title
JED turned to https
JED truned to https
avatar wilsonge wilsonge - change - 19 Sep 2016
Title
JED truned to https
JED turned to https
avatar wilsonge
wilsonge - comment - 19 Sep 2016

Is this ready now MAT?

avatar MATsxm MATsxm - change - 19 Sep 2016
Title
JED truned to https
JED turned to https
avatar MATsxm
MATsxm - comment - 19 Sep 2016

@wilsonge nope!

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar MATsxm
MATsxm - comment - 19 Sep 2016

@andrepereiradasilva @wilsonge
should be ok now?

avatar mbabker
mbabker - comment - 19 Sep 2016

Side note we probably should just regenerate all the test stub CSVs at one point.

avatar zero-24 zero-24 - change - 19 Sep 2016
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 19 Sep 2016
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 19 Sep 2016

RTC. based on the last reviews. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12076.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - close - 19 Sep 2016
avatar wilsonge wilsonge - change - 19 Sep 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-19 16:23:20
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 9 Oct 2016

Removed RTC label

avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment