? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
18 Sep 2016

Summary of Changes

Simple Pr to add the proper quotename to db query in component and library helper.

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 18 Sep 2016
avatar andrepereiradasilva andrepereiradasilva - change - 18 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2016
Category Libraries
avatar andrepereiradasilva andrepereiradasilva - change - 18 Sep 2016
Title
Correct/add quotename
Correct/add quoteName in component and library helper
avatar andrepereiradasilva andrepereiradasilva - edited - 18 Sep 2016
avatar wilsonge
wilsonge - comment - 19 Sep 2016

OK So I never knew that $db->quoteName(array('extension_id', 'element', 'params', 'enabled'), array('id', 'option', null, null)) worked (setting nulls in the second array). Thanks for teaching me something new!

avatar wilsonge wilsonge - change - 19 Sep 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-19 11:28:54
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Sep 2016
avatar wilsonge wilsonge - merge - 19 Sep 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Sep 2016

i discover that yesterday ;)

Add a Comment

Login with GitHub to post a comment