Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12060] - Make more use of the autoloader

? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
17 Sep 2016

Summary of Changes

Continued from #10881 and #10882 manual imports of files are replaced where practical with making use of the class autoloader.

Testing Instructions

Areas with changes this time include:

  • com_categories and it loading classes from other components
  • The Smart Search indexer
  • com_ajax and how it loads the helper files
  • Component routers when using legacy structures
  • JHtml in general
  • Extension manifest scripts
  • The extension adapters themselves
  • The cache API components
  • The loader methods in JDocument
  • JLanguage and its loading of a localise class
  • Components of the JForm API
  • MVC Layer

Pre- and post- patch all object should load as expected

Documentation Changes Required

Make the decision that the preferred best practice is to use the autoloader over include statements like these, since some insist on being able to overload classes this helps with being able to do that and since the CMS doesn't have a service layer this is the next best option.

avatar mbabker mbabker - open - 17 Sep 2016
avatar mbabker mbabker - change - 17 Sep 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2016
Category ⇒ Administration Components Tags CLI Front End Libraries
avatar andrepereiradasilva andrepereiradasilva - test_item - 17 Sep 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Sep 2016

I have tested this item ✅ successfully on 61ad456

Code review all seems fine.

Installed patch on 3.7.x branch, navigated a little in backend and frontend and all seems fine.
Installed extensions and languages, added articles, etc and all seems fine.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12060.

avatar zero-24
zero-24 - comment - 16 Oct 2016

@mbabker can you take a look here. It looks like there are some issues here with current 3.7.x?

If i apply this PR using patchtester i get on all backend views JS errors.

Maybe this is fixed by resync this one to 3.7.x as per definition how the patchtester works?

avatar mbabker
mbabker - comment - 16 Oct 2016

It's rebased.

Just as you pointed out, because of how patch tester works, the ability to apply a patch and test it with the component may or may not alter the testing environment and inherent results. It's much better to use a git client if one is available to you.

avatar zero-24 zero-24 - test_item - 16 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Oct 2016

I have tested this item ✅ successfully on 332b9f5

I have no git access on my shared host ;)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12060.

avatar zero-24 zero-24 - change - 16 Oct 2016
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 16 Oct 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12060.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 18 Oct 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-10-18 17:29:52
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 18 Oct 2016
avatar rdeutz rdeutz - merge - 18 Oct 2016
avatar brianteeman brianteeman - close - 18 Oct 2016
avatar brianteeman brianteeman - change - 18 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment