Feeling Lucky
?
?
[#12059] - [4.0] B/C Break - Typehint the database driver in JTable
- Fixed in Code Base
- 17 Sep 2016
- Medium
- Build: 4.0-dev
- # 12059
- Diff
- mbabker:JTable-db-typehint
- Success continuous-integration/drone the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JTable and its subclasses require the use of a JDatabaseDriver object to be passed in either the constructors or the setDbo() method however this is not enforced in the code except for a handful of subclasses which are already typehinting. This adds typehints for all of the classes to ensure the correct object is used. This also removes all of the referenced parameters, there's not a need for those anymore.
Testing Instructions
The CMS will continue to function as normal. There aren't any existing cases in normal operation where another object gets passed in.
Documentation Changes Required
- Subclasses of
JTablewill need to ensure they are passing aJDatabaseDriverobject to the parent constructor - Subclasses of
JTablewill need to change the method signature ofsetDbo()if they have an extended version of that method to include the typehint
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components Tags Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
|
||
zero-24
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-17 19:04:58 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 8 Apr 2017
I have tested this item✅ successfully on 720e47e
I made a code review only
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12059.