[#12037] - [com_users][fix] User profil changes and password reset won't work if logout menu exists and no login menu is shown
- Closed
- 23 Jul 2017
- Medium
- Build: staging
- # 12037
- Diff
- pmleconte:patch-1
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
com_users/router.php
Testing Instructions
Joomla 3.6.2, no specific module/extension/plugin
- create a logout menu
- create a login menu that will disappear when you are logged in (shown if the user is "invited")
- set "force password reset" to yes on one user
- login with this user
- user profile is displayed but you cannot access the passord change form.
Documentation Changes Required: no
If a logout menu item exists, users can not access to profil changes.
It means that the "force password reset" function won't work either.
com_users/Router.php creates a default link index.php/logout/profile?layout=edit that won't work, it blocks profile changes button et stays on profile display form.
The problem is that logout menu creates the following link :
index.php?option=com_users&view=login&layout=logout&task=user.menulogout
and the router just checks view=login, ignoring the view part of the link.
A "cleaner" solution could be to change the logout menu to become index.php?option=com_users&view=logout.
Pascal
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Information Required |
Hi Brian,
It does work because you have both login and logout menus.
In my configuration, after user login, the login menu disappears (only shown if you are "invited"), so there 's only Logout Menu. In this case, you cannot access the profile changes.
Pascal
| Title |
|
||||||
| Title |
|
||||||
I tried again and I still cannot replicate it - see https://www.dropbox.com/s/1eqn8wwgvg6sedg/reset.mp4?dl=0
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12037.
OK, one more condition: SEF mode should be ON (which is the default configuration).
Pascal
And now I can replicate the issue -thanks. Will test soon
| Status | Information Required | ⇒ | Pending |
I have tested this item
Thank you for being patient with me
I have now confirmed the issue and have applied the PR and it resolves the issue
Thanks!!!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12037.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12037.
This PR does not seem to be valid anymore. The tests by @brianteeman are from before a complete rewrite of the routers. The code like this has no function right now. I did not test the whole thing, but I would be surprised if that is still an issue in the current staging. In any case, if this PR is merged in the current form, it will just create a bunch of notices and nothing more. There will be no change to the router by this.
| Status | Pending | ⇒ | Needs Review |
| Category | Front End Components | ⇒ | Front End com_users Components |
@pmleconte Can you have a look to see if the issue still exists in 3.7.0 and if needed update your PR? Thank you.
| Status | Needs Review | ⇒ | Information Required |
If this PR get no Response, it will be closed at 23th July 2017.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-23 08:20:25 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2017-07-23 08:20:25 | ⇒ | 2017-07-23 08:20:27 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12037
closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12037.
Hello! O Joomla 3.8.1 I have the same problem. When i have 'logout' menu item (visible only for login user), user can't reset password.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12037.
@procajlok Please update on latest Release and ask further help on the forums. This repository concerns in first Place Joomla-Core coding, thanks.
I can NOT confirm your findings. As seen by the video everything works correctly - or do i misunderstand
