Fine by me. Some sources might say it should be great Britain not united kingdom but I don't really care

it should be great Britain not united kingdom but I don't really care

i actually add that doubt because en-GB means "English (Great Britain)", not "English (United Kingdom)" that, as you know better than i do, are different things.

I did look it up on the iso standards once to see what they said and it was
as clear as mud

We use GB as the two digit because UK is the Ukraine. But as the country
full name is The United Kingdom of Great Britain and Northern Ireland it is
best to write United Kingdom in this case

We use GB as the two digit because UK is the Ukraine. But as the country full name is The United Kingdom of Great Britain and Northern Ireland it is best to write United Kingdom in this case

yes just saw that right now in official iso codes page

UNITED KINGDOM OF GREAT BRITAIN AND NORTHERN IRELAND

https://www.iso.org/obp/ui/#iso:code:3166:GB

Can you use nativeName instead of native_name? Looks to be more consistent with other names in the XML.
Other than that I think it is a good move ?

yes we can will change

A list with all the native names exists here: https://github.com/dgt41/joomla-cms/blob/e17e53dcb8a764765c1d6b81933c5854b94d9a6a/plugins/editors/tinymce/helpers/tinymce.php
(If that would be somewhat helpful)

@dgt41 Unfortunately that doesn't help as it is not complete in the sense we need. Eg it has only one entry for "de" (no de-DE, de-CH, de-LI, de-AT, de-LU) and it is exactly where the current issue is coming from. ?

You're sure you want to mix all those codestyle and SQL stuff into this PR?
The first changes could have been merged by review alone, but now this becomes a regular PR which needs testing instructions and regular tests.

@Bakual i know, the problem is the unit tests ... because of the inconsistency of the language names across joomla (which is really annoying ....!) Every time i try to change something in language i got problems because in some place is "(en-GB)", other is "(UK)", others is "(United Kingdom)" ...

IMHO, if we are changing the native title to be "English (United Kingdom)" and the international name being "English (en-GB)" we need to reflect this across joomla (install sql, unit tests, xml files, etc).

Also had to make a series of changes to have valid unit tests.
Basicly added consistency to all language names across joomla and unit tests.

You're sure you want to mix all those codestyle and SQL stuff into this PR?
The first changes could have been merged by review alone, but now this becomes a regular PR which needs testing instructions and regular tests.

This will probably only be merged in 3.7.x so ... i see no issue with that.

The most important test continues to be a code review.
More tests i will write them after.

updated test instruction in the PR description.

@andrepereiradasilva
If this goes in (OK for me for 3.7), let's also add the new metadata proposed for the new calendar at the same time.
#11138

just tell what is the metadata needed and if @dgt41 agrees i can add in this PR too, or we can wait for this one to get tested and eventually merged in 3.7.x branch and then add the calendar metadata.

The new metadata is
<calendar>jalali</calendar>
or
<calendar>gregorian</calendar>
for now (other calendars may be added in the future).

If not present it would use gregorian.

ok added the calendar type to site and admin metadata xml. Didn't add it to install because i think it's not used there.

also updated PR description.

Please do a general code review and test.

Didn't add it to install because i think it's not used there.

No problem, I did that on the other PR ? (for the shake of unification)

Example: gregorian, javali

"jalali" ;)

Please milestone to 3.7

"jalali" ;)

ehhehe corrected

ok now it will use the new nativeTitle (if exists) on language install to create the content language native title as it should be.

It will still fallback to the install language variable (that should then be removed in 4.0).

I have tested this item ✅ successfully on d3e9986

?

I have tested this item ✅ successfully on d3e9986

RTC