[#12023] - RTL grid columns hardcoded
- Closed
- 14 Sep 2016
- Medium
- Build: staging
- # 12023
Steps to reproduce the issue
Review https://github.com/joomla/joomla-cms/blob/3.6.2/media/jui/less/bootstrap-rtl.less#L34-L50
Expected result
Grid widths should be calculated based on the variables defined by a template.
Actual result
Grid widths are hardcoded causing inconsistent display when RTL is in use.
System information (as much as possible)
N/A
Additional comments
To demonstrate the issues this causes, go to https://issues.joomla.org/markdown and view the page with the Arabic language enabled. Inspect the page and find one of the span6 elements. Note the widths coming from the RTL CSS file (which is compiled using the core Bootstrap file; the grid widths are NOT overridden by the joomla.org site template) and note the values it overrides from the "normal" CSS files. If variables were in use, the right margin for the RTL CSS would be the correct 2.564102564102564% value versus the hardcoded 2.127659574%.
zero-24
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-14 13:53:17 |
| Closed_By | ⇒ | mbabker |
brianteeman
- | Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
Nevermind. Closing as can't fix without B/C breaks. Basically every template is going to need their own RTL LESS and will need to copy the core file (if they want to use it as a starting point) to be able to pass variables in. It should be noted though that the default RTL LESS and CSS are faulty without being fixable.