[#11990] - Remove unneeded metadata.xml files
- Fixed in Code Base
- 5 Nov 2016
- Medium
- Build: staging
- # 11990
- Diff
- Bakual:RemoveMetadataXml
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Currently, we have metadata.xml files in each view. However since Joomla 3.5.0 those are no longer required (PR #7654).
Summary of Changes
This PR removes the metadata.xml files since they have no function at all in core.
This will help extension developers to see best practices.
Testing Instructions
- Test creating menu items for the affected views. Nothing strange should happen.
- Check the menu item type text in the menu item manager, see picture. Nothing should change there.
### Documentation Changes Required
None to my knowledge.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Components Tags |
| Labels |
Added:
?
|
||
I have tested this item
I didn't found a posibility to test the views of com_mailto because there are no selectable views (XML-files are missing).
All other was working.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990.
Should we have these files in script.php at the same time?
Yes
It starts to become a mess if you have some sites with files and some sites without. Especially security scanners. If the files are not needed then they should be removed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11990.
| Category | Front End Components Tags | ⇒ | Administration Components Front End Tags |
Added the files to the script.php. If it's not merged for 3.6.3 that files needs to be adjusted so the comment matches :)
The Hello world example component code/development tutorial likely needs a major update to match with 3.5+ best practices like the removal of metadata.xml. (I think it was last revised with 3.2)
@photodude I had a look but couldn't find anything related to metadata.xml on a first glance. At least not where I would have expected it (https://docs.joomla.org/J3.x:Developing_an_MVC_Component/Adding_a_menu_type_to_the_site_part)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11990.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-05 09:23:33 |
| Closed_By | ⇒ | rdeutz |
Documentation Changes
RequiredSuggestedThe Hello world example component code/development tutorial likely needs a major update to match with 3.5+ best practices like the removal of metadata.xml. (I think it was last revised with 3.2)