? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
8 Sep 2016

Pull Request for Code Style Issues .

Summary of Changes

  • Please consider an empty line before the if statement
  • No blank line found after control structure
  • Blank line found at start of control structure
  • Expected 1 newline after opening brace; 2 found
  • Expected 0 spaces before closing bracket; 1 found
  • Please consider an empty line before the return statement
  • Object operator not indented correctly
  • Expected "boolean" but found "bool" for function return type
  • Line exceeds 150 characters

Automatically fixed with PHPCS2 fixers

Testing Instructions

Merge by Code review

Documentation Changes Required

none

avatar photodude photodude - open - 8 Sep 2016
avatar photodude photodude - change - 8 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2016
Category Administration Components
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2016
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Sep 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 8 Sep 2016

RTC on review thanks ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11989.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2016
Labels Added: ?
avatar photodude photodude - edited - 8 Sep 2016
avatar photodude photodude - change - 8 Sep 2016
The description was changed
avatar photodude photodude - edited - 8 Sep 2016
avatar rdeutz rdeutz - close - 8 Sep 2016
avatar rdeutz rdeutz - merge - 8 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 8 Sep 2016
avatar rdeutz rdeutz - change - 8 Sep 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-09-08 17:17:04
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2016
Labels Removed: ?
avatar photodude photodude - change - 29 Apr 2017
The description was changed
avatar photodude photodude - edited - 29 Apr 2017
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2017
Category Administration Components Administration com_content Components

Add a Comment

Login with GitHub to post a comment