[#11954] - Adding CDATA to description in en-GB language package manifest.
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11954
- Diff
- Bakual:WrapDescriptionInCDATA
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
In Crowdin, when a translator tries to add a CDATA tag to the description it will be blocked because it isn't present in the source string. This PR adds it to the source string so the translators have an easier life on Crowdin.
Summary of Changes
Adds <![CDATA[ ... ]]> to the <description> tag in the en-GB package manifest.
Testing Instructions
- Go to Extension Manager -> Manager and filter for "eng" to get the en-GB packages.
- Select all three of them and click "Refresh Cache".
- Check the tooltips that they still work as expected.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration |
Is this only needed in this particular pkg_xx-XX.xml manifest? Or should be applied to all xmls?
I thought the description is only used during installation, and thus the package manifest would be the only place it is needed. But checking further you're right, it is used also in the extension manager in a tooltip. I'm going to update the en-GB.xml files as well.
I don't know if the description in the install.xml manifests are used for anything.
The files in the installation folder don't have the description tag anyway.
Also found a way to test this:
1. Go to Extension Manager -> Manager and filter for "eng" to get the en-GB packages.
2. Select all three of them and click "Refresh Cache".
3. Check the tooltips that they still work as expected.
| Category | Administration | ⇒ | Language & Strings Administration |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11954.
created a fake lp to check what is used where (there are so many ...)
xx-XX-languagepackage.zip
it confirms what you say, install.xml description is not used anywhere in the core.
Also made the test described and works as expected.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11954.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
I have tested this item
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11954.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 19:51:13 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Fine by me