? ? ? ? Failure

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
5 Sep 2016

Summary of Changes

If template providers wish to use a CSS pre-processor, they're limited to LESS as this is what Joomla supports by default. This PR adds SCSS support as show in the screenshot below:

screeny

Testing Instructions

  • Download this zip
  • Extract to administrator/template/isis
  • In the Template Manager, go to Templates >> Isis >> scss >> test.scss
  • Click "Compile SCSS"

Despite it working, I don't think I've called the library correctly. I tried going through Joomla's JLoader but with no avail, so if someone could point me in the right direction for that, it would be appreciated.

avatar C-Lodder C-Lodder - open - 5 Sep 2016
avatar C-Lodder C-Lodder - change - 5 Sep 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2016
Category Administration Components Language & Strings External Library Libraries
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2016
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2016
Labels Added: ? ? ?
avatar C-Lodder C-Lodder - change - 5 Sep 2016
Title
Add SCSS compiler for Template Providers
Add SCSS compiler to Template
avatar dgt41
dgt41 - comment - 5 Sep 2016

try use Leafo\ScssPhp\Compiler;

avatar C-Lodder
C-Lodder - comment - 5 Sep 2016

Already did. Undefined class on the extend

avatar mbabker
mbabker - comment - 5 Sep 2016

The Composer lock file is not correctly updated not is Composer's
autoloader. Fix that and you fix your issue.

On Monday, September 5, 2016, Lodder notifications@github.com wrote:

Already did. Undefined class on the extend


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11941 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfofIvBb_XhPUh_3gi17gAVpvKfTNJks5qnEuCgaJpZM4J1NqR
.

avatar C-Lodder
C-Lodder - comment - 5 Sep 2016

Cheers micheal. Will do when I get home

avatar mbabker
mbabker - comment - 5 Sep 2016

Also, this can't be accepted. The library requires PHP 5.4.

On Monday, September 5, 2016, Lodder notifications@github.com wrote:

Already did. Undefined class on the extend


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11941 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfofIvBb_XhPUh_3gi17gAVpvKfTNJks5qnEuCgaJpZM4J1NqR
.

avatar dgt41
dgt41 - comment - 5 Sep 2016

@mbabker not even if the button is rendered for php>5.4 ??

avatar mbabker
mbabker - comment - 5 Sep 2016

The only PHP conditional behaviors we have IIRC are either pretty printing
JSON strings in the debug plugin or using polyfilled functions. We don't
have features that are PHP version limited.

On Monday, September 5, 2016, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@mbabker https://github.com/mbabker not even if the button is rendered
for php>5.4 ??


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11941 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfod5AVibgtDtdt2aAtS6JZHO8g3yYks5qnE2PgaJpZM4J1NqR
.

avatar brianteeman
brianteeman - comment - 5 Sep 2016

Not a good precedent to set having features limited by php version

avatar dgt41
dgt41 - comment - 5 Sep 2016

@mbabker @brianteeman that was just an idea.
I am packing leafo's scss as a library for some time now and will continue to do if joomla doesn't provide a compiler for scss...

avatar brianteeman
brianteeman - comment - 5 Sep 2016

At this point I am sorry but I am going to have to close this for the reasons stated above.

avatar brianteeman brianteeman - change - 5 Sep 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-09-05 17:31:48
Closed_By brianteeman
avatar C-Lodder
C-Lodder - comment - 5 Sep 2016

Ughr, I bloody well hope the min PHP version is bumped up in 4.x

avatar Bakual
Bakual - comment - 5 Sep 2016

Ughr, I bloody well hope the min PHP version is bumped up in 4.x

It for sure will be bumped. Likely at least to 5.6.

avatar C-Lodder
C-Lodder - comment - 5 Sep 2016

Could we not keep this open and label it with "Re-evaluate for v4.0"?

avatar mbabker
mbabker - comment - 5 Sep 2016

Ughr, I bloody well hope the min PHP version is bumped up in 4.x

We'll do it long before WordPress ever does :trollface:

avatar brianteeman brianteeman - change - 5 Sep 2016
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 5 Sep 2016

@mbabker - Is it possible for me to copy the Unit Tests from the SCSSPHP repo, add them to Joomla's tests and see if anything fails on PHP 5.3 with Travis?

avatar mbabker
mbabker - comment - 5 Sep 2016

Don't bother. The first file I looked at makes use of short array syntax.

avatar brianteeman
brianteeman - comment - 5 Sep 2016

Its a fairly new requirement for leafo that looks like it was made for
political not code reasons

On 5 September 2016 at 18:58, Lodder notifications@github.com wrote:

@mbabker https://github.com/mbabker - Is it possible for me to copy the
Unit Tests from the SCSSPHP repo, add them to Joomla's tests and see if
anything fails on PHP 5.3 with Travis?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#11941 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ceu8GaBEegeAgZLAC418l015EErks5qnFhbgaJpZM4J1NqR
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 5 Sep 2016

Posted at the same time as @mbabker clearly they decided to take advantage
of 5.4+ stuff

On 5 September 2016 at 19:01, Brian Teeman brian@teeman.net wrote:

Its a fairly new requirement for leafo that looks like it was made for
political not code reasons

On 5 September 2016 at 18:58, Lodder notifications@github.com wrote:

@mbabker https://github.com/mbabker - Is it possible for me to copy
the Unit Tests from the SCSSPHP repo, add them to Joomla's tests and see if
anything fails on PHP 5.3 with Travis?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#11941 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ceu8GaBEegeAgZLAC418l015EErks5qnFhbgaJpZM4J1NqR
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment