Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11922] - Bootstrap javascript components initiator

? ? Success

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
4 Sep 2016

Pull Request for Issue #11654

Summary of Changes

  • No more inline scipts for bootstrap components
  • Make Joomla's bootstrap (js) dependancy less strict, as the init script together with the jlayouts dictate the js framework. For example someone can override bootstrap.js, bootstrap-init.js and the layouts and use Foundation or Ukit or any other framework!

Testing Instructions

You will Need to use 3.7 branch for testing!!!

For modals, tooltips, popover and tabs apply this patch and navigate to isis template on the backend. Ensure that no javascript errors are logged and everything still works.
To test the other bootstrap components download this module https://github.com/dgt41/bootstrap-test/raw/gh-pages/bootstrap_test.zip install, publish in the front end and then visit that page (template must be protostar).
Enjoy!

B/C

There are few layouts that are touched, but joomla's b/c promise states that these are not B/C breaks. Down to PLT for a decision on that.

Documentation Changes Required

None.

This change is Reviewable

avatar dgt41 dgt41 - open - 4 Sep 2016
avatar dgt41 dgt41 - change - 4 Sep 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2016
Category ⇒ Layout Libraries JavaScript Unit Tests
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2016
Labels Added: ? ?
avatar dgt41 dgt41 - change - 4 Sep 2016
The description was changed
avatar brianteeman brianteeman - close - 4 Sep 2016
avatar brianteeman
brianteeman - comment - 4 Sep 2016

If you are removing a file please add it to the list in script.php

avatar brianteeman brianteeman - change - 4 Sep 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-09-04 15:06:34
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - reopen - 4 Sep 2016
avatar brianteeman brianteeman - change - 4 Sep 2016
Status Closed ⇒ New
Closed_Date 2016-09-04 15:06:34 ⇒
Closed_By brianteeman ⇒
avatar brianteeman brianteeman - change - 4 Sep 2016
Status New ⇒ Pending
avatar dgt41
dgt41 - comment - 4 Sep 2016

@brianteeman done, thanks!

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Oct 2016

this seems to work fine.

side note: have the other tabs issue (Permissions Tab selected) (#11648) but not related to this PR.

avatar zero-24 zero-24 - change - 6 Oct 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 8 Oct 2016

I have notices that in the backend the Edit Tooltips (e.g. com_content) don't work anymore as bs tooltips there are just browser tooltips.

Also I'm not sure if this is a bug here or in the mod if i show it in the frontend it looks like this:
image

See the kitten on the debug console. Also the page is jumping.

What is Affix supposed to do?

image

avatar dgt41 dgt41 - change - 12 Oct 2016
Title
…
Rebase #11654 for 3.7
Bootstrap javascript components initiator
avatar dgt41 dgt41 - change - 12 Oct 2016
Title
…
Rebase #11654 for 3.7
Bootstrap javascript components initiator
avatar dgt41
dgt41 - comment - 12 Oct 2016

@zero-24 try to use the module in an article with {loadmodule...} or {loadposition...}. This module wasn't created or tested for narrow positions (left, right etc), so that might be a problem.
Affix just sticks the image to a given value (in px) so when you scroll the image should remain in the same position

avatar zero-24 zero-24 - test_item - 16 Oct 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Oct 2016

I have tested this item ✅ successfully on cbcb940

? Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

avatar brianteeman brianteeman - change - 29 Oct 2016
Labels Added: ?
Removed: ?
avatar hans2103 hans2103 - test_item - 4 Nov 2016 - Tested successfully
avatar hans2103
hans2103 - comment - 4 Nov 2016

I have tested this item ✅ successfully on cbcb940

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2016
Category Layout Libraries JavaScript Unit Tests ⇒ Administration Components Layout Libraries JavaScript Unit Tests
avatar dgt41
dgt41 - comment - 4 Nov 2016

Conflicts resolved

avatar roland-d
roland-d - comment - 4 Nov 2016

@zero-24 and @hans2103 Can you test once more? Thanks.

avatar hans2103
hans2103 - comment - 4 Nov 2016

I have tested this item ✅ successfully on 9e0f4bd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

avatar hans2103 hans2103 - test_item - 4 Nov 2016 - Tested successfully
avatar dgt41 dgt41 - change - 4 Nov 2016
Labels Added: ?
avatar roland-d
roland-d - comment - 5 Nov 2016

@dgt41 I am afraid there is a new conflict.

8a6cd11 5 Nov 2016 avatar dgrammatiko CS
7134558 5 Nov 2016 avatar dgrammatiko oops
58bf902 5 Nov 2016 avatar dgrammatiko oops
7f7b06c 5 Nov 2016 avatar dgrammatiko UT
7fe7096 5 Nov 2016 avatar dgrammatiko UT
2e57097 5 Nov 2016 avatar dgrammatiko UT
7710044 5 Nov 2016 avatar dgrammatiko oops
avatar dgt41
dgt41 - comment - 5 Nov 2016

@roland-d and fixed

avatar dgt41 dgt41 - change - 14 Nov 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-14 11:42:20
Closed_By ⇒ dgt41
avatar dgt41 dgt41 - close - 14 Nov 2016
avatar dgt41 dgt41 - close - 14 Nov 2016
avatar zero-24 zero-24 - close - 14 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Nov 2016
Category Layout Libraries JavaScript Unit Tests Administration Components ⇒ Administration com_admin Layout Libraries JavaScript Unit Tests Components
avatar zero-24
zero-24 - comment - 14 Nov 2016

@dgt41 did you want to close this? So this should be removed from the mileston too?

avatar zero-24 zero-24 - change - 14 Nov 2016
Milestone Removed:
avatar dgt41
dgt41 - comment - 14 Nov 2016

First of all a big thank you to all the people spend some time with this PR.
An now the explanation why I closed it:
My main idea here was

  • remove the inline script
  • get the code ready for some Joomla.ui API that would freed joomla from any javascript framework.

I am sorry that I have wasted people's precious time here ?

avatar zero-24
zero-24 - comment - 14 Nov 2016

Thanks ?

avatar dgt41 dgt41 - change - 3 Dec 2016
The description was changed
Status Closed ⇒ Pending
Closed_Date 2016-11-14 11:42:16 ⇒
Closed_By dgt41 ⇒
avatar dgt41 dgt41 - change - 3 Dec 2016
Labels Removed: ?
avatar dgt41 dgt41 - change - 3 Dec 2016
Labels Added: ?
avatar dgt41 dgt41 - edited - 3 Dec 2016
avatar dgt41 dgt41 - reopen - 3 Dec 2016
avatar dgt41 dgt41 - reopen - 3 Dec 2016
avatar dgt41 dgt41 - change - 5 Dec 2016
The description was changed
Labels Removed: ? ?
avatar dgt41 dgt41 - edited - 5 Dec 2016
avatar dgt41 dgt41 - change - 13 Mar 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-13 12:09:13
Closed_By ⇒ dgt41
Labels Added: ? ?
avatar dgt41 dgt41 - close - 13 Mar 2017

Add a Comment

Login with GitHub to post a comment