[#11890] - Add Microseconds to JDate('now')
- Fixed in Code Base
- 6 Sep 2016
- Medium
- Build: staging
- # 11890
- Diff
- andrepereiradasilva:patch-26
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
As discussed in #11888 this PR adds the microsconds when creating a JDate('now') so 'now' is really 'now' and not with a delay up to 0.99(9) seconds.
Testing Instructions
- Add to protostar/isis index.php the following code.
$date1 = new JDate('now'); usleep(1000); $date2 = new JDate('now');
$app->enqueueMessage($date1->format('Y-m-d H:i:s.u') . '<br />' . $date2->format('Y-m-d H:i:s.u'), 'notice');- Reload page. Before patch the dates are equal with 0 microseconds.
- Apply patch. You should see the dates are different and you should see the microsecond in the notice message.
- Test if Joomla works fine.
Documentation Changes Required
This page in the docs should probably be updated https://docs.joomla.org/How_to_use_JDate
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
- I have tested successfully
-
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11890.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11890.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
This page in the docs should probably be updated https://docs.joomla.org/How_to_use_JDate
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11890.
ok updated PR description
Nothing there needs updating as there's no documentation about microseconds not being honored before the patch or any notes about incompatibilities with microsecond formats (which there wouldn't be any; all the formatting is done by the parent DateTime class, we just had a limitation that kept "now" from storing microseconds when instantiating the object).
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 21:34:27 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item✅ successfully on 90cc89a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11890.