[#11889] - Insert link on an image with tinymce - modal doesnt close
- Closed
- 9 Dec 2016
- Medium
- Build: master
- # 11889
Steps to reproduce the issue
- Create some text and highlight it and click on the icon to create a link. Add a url and click ok.
- Add an image and highlight it and click on the icon to create a link. Add a url and click ok.
Expected result
In both cases the link should be added and the modal closed
Actual result
In case 2 the link is added but the modal does not close when you select ok
System information (as much as possible)
Current staging
Votes
I have followed above steps and able to reproduce this issue.
| Status | New | ⇒ | Confirmed |
| Category | ⇒ | Plugins |
Joomla currently uses v4.4.1 of TinyMCE. Do you get the same issue on v4.4.3?
Dam - why do they never email on updates on minor releases.
On 2 September 2016 at 17:26, Lodder notifications@github.com wrote:
Joomla currently uses v4.4.1 of TinyMCE. Do you get the same issue on
v4.4.3?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11889 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eGkxGtb32wrA3UDo7lDeHG-tTFsks5qmE4qgaJpZM4Jzon4
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Its not in the bug list but as I have to do an update PR for tinymce I can
double check then
On 2 September 2016 at 17:47, Brian Teeman brian@teeman.net wrote:
Dam - why do they never email on updates on minor releases.
On 2 September 2016 at 17:26, Lodder notifications@github.com wrote:
Joomla currently uses v4.4.1 of TinyMCE. Do you get the same issue on
v4.4.3?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11889 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eGkxGtb32wrA3UDo7lDeHG-tTFsks5qmE4qgaJpZM4Jzon4
.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have done a PR for updating tinymce see #11894
However it doesnt resolve this issue
On 2 September 2016 at 17:49, Brian Teeman brian@teeman.net wrote:
Its not in the bug list but as I have to do an update PR for tinymce I can
double check thenOn 2 September 2016 at 17:47, Brian Teeman brian@teeman.net wrote:
Dam - why do they never email on updates on minor releases.
On 2 September 2016 at 17:26, Lodder notifications@github.com wrote:
Joomla currently uses v4.4.1 of TinyMCE. Do you get the same issue on
v4.4.3?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11889 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eGkxGtb32wrA3UDo7lDeHG-tTFsks5qmE4qgaJpZM4Jzon4
.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Labels |
Added:
?
|
||
This is still an issue with the current staging
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11889.
I have the same issue with 4.4.3. Error occurs at line 36 of Hooks.js
Firefox says:
TypeError: hook is not a function
hook(editor);
I fixed it by adding if (typeof hook == 'function') before line 36 (hook(editor);) in the dev version.
To fix the minified version find function i(e,t){s(o[e],function(e){e(t)})}} and replace with function i(e,t){s(o[e],function(e){if (typeof e == 'function'){e(t)}})
Note: This is a DIRTY FIX! I have no idea about what that hook(editor) does, so some side effects may occur.
@infograf768 I've started debugging this few weeks ago and found that a plugin is responsible for that, bad news I can't find the related branch, stash on my machine right now (means I need to redo this
@brianteeman can't reproduce it anymore: http://www.giphy.com/gifs/26ybuWARgxEGeviaA
Ok I will retest
On 9 Dec 2016 1:46 p.m., "Dimitri Grammatikogianni" <
notifications@github.com> wrote:
@brianteeman https://github.com/brianteeman can't reproduce it anymore:
http://www.giphy.com/gifs/26ybuWARgxEGeviaA—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11889 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R9BROD1foSqL54yx5wdW6MksDphks5rGVujgaJpZM4Jzon4
.
So long and farewell
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 15:34:55 |
| Closed_By | ⇒ | brianteeman |
Console shows the following